Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337380

Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Feb 15, 2016 at 02:22:22PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> This driver uses functionality (MSI IRQ domain) whose symbols aren't
> exported, and hence the modular build fails. While arguably there might
> be reasons to make these symbols available to modules, that change would
> be fairly involved and the set of exported functions should be carefully
> auditioned. Fix the build failure for now by marking the driver boolean.
> 
> Cc: J. German Rivera <German.Rivera@freescale.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/staging/fsl-mc/bus/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sorry for being pushy, but this has had allmodconfig builds broken in
linux-next for a couple of days now. The driver has been marked BROKEN
now in linux-next to remedy that, but having proper fixes seems better
than that.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: fsl-mc: Do not allow building as a module Thierry Reding <thierry.reding@gmail.com> - 2016-02-15 14:30 +0100
  Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module Thierry Reding <thierry.reding@gmail.com> - 2016-02-18 15:10 +0100
    Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-19 05:40 +0100

csiph-web