Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1332528 > unrolled thread

[PATCH 1/4] mfd: max77686: Add max77802 to I2C device ID table

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2016-02-12 05:40 +0100
Last post2016-02-15 06:30 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/4] mfd: max77686: Add max77802 to I2C device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-12 05:40 +0100
    Re: [PATCH 1/4] mfd: max77686: Add max77802 to I2C device ID table Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-15 06:30 +0100

#1332528 — [PATCH 1/4] mfd: max77686: Add max77802 to I2C device ID table

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-02-12 05:40 +0100
Subject[PATCH 1/4] mfd: max77686: Add max77802 to I2C device ID table
Message-ID<r1dGq-1XX-9@gated-at.bofh.it>
The max77686 MFD driver supports both the Maxim 77686 and Maxim 77802
PMICs but only the OF device table contains entries for both devices.

The max77802 entry is missing in the I2C device ID table which isn't
a problem currently since the driver only supports DT but it will be
needed if the driver is changed to be built as a module since the I2C
core always reports a I2C modalias uevent so auto-load will not work.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/mfd/max77686.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index d959ebbb2194..1f30c97d6d4e 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c
@@ -345,6 +345,7 @@ static int max77686_i2c_remove(struct i2c_client *i2c)
 
 static const struct i2c_device_id max77686_i2c_id[] = {
 	{ "max77686", TYPE_MAX77686 },
+	{ "max77802", TYPE_MAX77802 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, max77686_i2c_id);
-- 
2.5.0

[toc] | [next] | [standalone]


#1334156

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-02-15 06:30 +0100
Message-ID<r2jTr-4Xm-1@gated-at.bofh.it>
In reply to#1332528
On 12.02.2016 13:30, Javier Martinez Canillas wrote:
> The max77686 MFD driver supports both the Maxim 77686 and Maxim 77802
> PMICs but only the OF device table contains entries for both devices.
> 
> The max77802 entry is missing in the I2C device ID table which isn't
> a problem currently since the driver only supports DT but it will be
> needed if the driver is changed to be built as a module since the I2C
> core always reports a I2C modalias uevent so auto-load will not work.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/mfd/max77686.c | 1 +
>  1 file changed, 1 insertion(+)


Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web