Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332658 > unrolled thread

[PATCH] net: phy: spi_ks8995: add dependency on GPIO

Started bySudip Mukherjee <sudipm.mukherjee@gmail.com>
First post2016-02-12 11:20 +0100
Last post2016-02-13 15:10 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] net: phy: spi_ks8995: add dependency on GPIO Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-12 11:20 +0100
    Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO Helmut Buchsbaum <helmut.buchsbaum@gmail.com> - 2016-02-12 13:40 +0100
    Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-13 11:20 +0100
      Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-13 15:10 +0100

#1332658 — [PATCH] net: phy: spi_ks8995: add dependency on GPIO

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2016-02-12 11:20 +0100
Subject[PATCH] net: phy: spi_ks8995: add dependency on GPIO
Message-ID<r1iZr-5zo-1@gated-at.bofh.it>
The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
with the error:
 drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
 drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'

GPIO is now used to reset the switch so we should have a dependency on
GPIOLIB. 

Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/net/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index f0a7702..c6a4fe1 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -261,4 +261,4 @@ endif # PHYLIB
 
 config MICREL_KS8995MA
 	tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch"
-	depends on SPI
+	depends on SPI && GPIOLIB
-- 
1.9.1

[toc] | [next] | [standalone]

#1332702

FromHelmut Buchsbaum <helmut.buchsbaum@gmail.com>
Date2016-02-12 13:40 +0100
Message-ID<r1laV-6YA-1@gated-at.bofh.it>
In reply to#1332658
On 02/12/2016 11:18 AM, Sudip Mukherjee wrote:
> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
> with the error:
>   drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
>   drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
>
> GPIO is now used to reset the switch so we should have a dependency on
> GPIOLIB.
>
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
> Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>   drivers/net/phy/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index f0a7702..c6a4fe1 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -261,4 +261,4 @@ endif # PHYLIB
>
>   config MICREL_KS8995MA
>   	tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch"
> -	depends on SPI
> +	depends on SPI && GPIOLIB
>
You're definitely right! This somehow slipped through, sorry for that!

[toc] | [prev] | [next] | [standalone]

#1333295

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2016-02-13 11:20 +0100
Message-ID<r1Ft0-3oJ-5@gated-at.bofh.it>
In reply to#1332658
On Fri, Feb 12, 2016 at 11:18 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
> with the error:
>  drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
>  drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'

Does that file include include/linux/gpio/consumer.h?
The GPIO subsystem provides dummies of these functions when CONFIG_GPIOLIB=n.

> GPIO is now used to reset the switch so we should have a dependency on
> GPIOLIB.
>
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
> Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/net/phy/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index f0a7702..c6a4fe1 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -261,4 +261,4 @@ endif # PHYLIB
>
>  config MICREL_KS8995MA
>         tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch"
> -       depends on SPI
> +       depends on SPI && GPIOLIB

I think that can become

    depends on SPI
    depends on GPIOLIB || COMPILE_TEST

after you've added the missing include.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1333326

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2016-02-13 15:10 +0100
Message-ID<r1J3z-5Rv-1@gated-at.bofh.it>
In reply to#1333295
On Saturday 13 February 2016 03:42 PM, Geert Uytterhoeven wrote:
> On Fri, Feb 12, 2016 at 11:18 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
>> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
>> with the error:
>>   drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
>>   drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
>
> Does that file include include/linux/gpio/consumer.h?
> The GPIO subsystem provides dummies of these functions when CONFIG_GPIOLIB=n.
>
>> GPIO is now used to reset the switch so we should have a dependency on
>> GPIOLIB.
>>
>> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
>> Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>> ---
>>   drivers/net/phy/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
>> index f0a7702..c6a4fe1 100644
>> --- a/drivers/net/phy/Kconfig
>> +++ b/drivers/net/phy/Kconfig
>> @@ -261,4 +261,4 @@ endif # PHYLIB
>>
>>   config MICREL_KS8995MA
>>          tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch"
>> -       depends on SPI
>> +       depends on SPI && GPIOLIB
>
> I think that can become
>
>      depends on SPI
>      depends on GPIOLIB || COMPILE_TEST
>
> after you've added the missing include.

yes, ofcourse. Better change that what I have done. Just sent v2 after 
compile testing this change.

regards
sudip

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web