Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1332658

[PATCH] net: phy: spi_ks8995: add dependency on GPIO

From Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] net: phy: spi_ks8995: add dependency on GPIO
Date 2016-02-12 11:20 +0100
Message-ID <r1iZr-5zo-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
with the error:
 drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
 drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'

GPIO is now used to reset the switch so we should have a dependency on
GPIOLIB. 

Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/net/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index f0a7702..c6a4fe1 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -261,4 +261,4 @@ endif # PHYLIB
 
 config MICREL_KS8995MA
 	tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch"
-	depends on SPI
+	depends on SPI && GPIOLIB
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: phy: spi_ks8995: add dependency on GPIO Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-12 11:20 +0100
  Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO Helmut Buchsbaum <helmut.buchsbaum@gmail.com> - 2016-02-12 13:40 +0100
  Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-13 11:20 +0100
    Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-13 15:10 +0100

csiph-web