Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1333329 > unrolled thread

Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Linus Walleij <linus.walleij@linaro.org> - 2016-02-13 15:50 +0100
    Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-02-13 18:20 +0100

#1333329 — Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support

On Mon, Feb 1, 2016 at 1:09 PM, Maxime Coquelin <maxime.coquelin@st.com> wrote:
> On 02/01/2016 11:39 AM, Maxime Coquelin wrote:
>> 2016-02-01 11:21 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:

>>> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error:
>>> dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory
>>
>> Right, I missed to notify this dependency to Linus, sorry about that.
>> This dependency is no more needed, so I could just move the macros to
>> the driver side.
>>
>> Note that I also noticed a breakage at build time due to field
>> renaming in gpio_chip structure (dev -> parent).
>>
>> I propose to rebase the series and move the defines into the driver.
>> Is it ok for you?
>>
> I have rebased the series, taking care to fix the mentioned problems.
>
> Linus, do you confirm you will revert STM32 pinctrl patches from your tree?

I guess the other fixes removes the need to do this.

Sorry for not staying on top of this issue, I was swamped with mail
and had a hard time prioritizing :(

Yours,
Linus Walleij

[toc] | [next] | [standalone]

#1333343

On 02/13/2016 03:48 PM, Linus Walleij wrote:
> On Mon, Feb 1, 2016 at 1:09 PM, Maxime Coquelin <maxime.coquelin@st.com> wrote:
>> On 02/01/2016 11:39 AM, Maxime Coquelin wrote:
>>> 2016-02-01 11:21 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
>
>>>> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error:
>>>> dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory
>>>
>>> Right, I missed to notify this dependency to Linus, sorry about that.
>>> This dependency is no more needed, so I could just move the macros to
>>> the driver side.
>>>
>>> Note that I also noticed a breakage at build time due to field
>>> renaming in gpio_chip structure (dev -> parent).
>>>
>>> I propose to rebase the series and move the defines into the driver.
>>> Is it ok for you?
>>>
>> I have rebased the series, taking care to fix the mentioned problems.
>>
>> Linus, do you confirm you will revert STM32 pinctrl patches from your tree?
>
> I guess the other fixes removes the need to do this.
Exactly, all should be fine now.

>
> Sorry for not staying on top of this issue, I was swamped with mail
> and had a hard time prioritizing :(

No worries!

Thanks,
Maxime

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web