Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support
Date	2016-02-13 15:50 +0100
Message-ID	<r1JGi-66L-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <qQP2G-6Qm-7@gated-at.bofh.it> <qVyaS-3Zx-3@gated-at.bofh.it> <qXjU6-19m-9@gated-at.bofh.it> <qXk3M-1dK-19@gated-at.bofh.it> <qXlCx-2xe-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 1, 2016 at 1:09 PM, Maxime Coquelin <maxime.coquelin@st.com> wrote:
> On 02/01/2016 11:39 AM, Maxime Coquelin wrote:
>> 2016-02-01 11:21 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:

>>> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error:
>>> dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory
>>
>> Right, I missed to notify this dependency to Linus, sorry about that.
>> This dependency is no more needed, so I could just move the macros to
>> the driver side.
>>
>> Note that I also noticed a breakage at build time due to field
>> renaming in gpio_chip structure (dev -> parent).
>>
>> I propose to rebase the series and move the defines into the driver.
>> Is it ok for you?
>>
> I have rebased the series, taking care to fix the mentioned problems.
>
> Linus, do you confirm you will revert STM32 pinctrl patches from your tree?

I guess the other fixes removes the need to do this.

Sorry for not staying on top of this issue, I was swamped with mail
and had a hard time prioritizing :(

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Linus Walleij <linus.walleij@linaro.org> - 2016-02-13 15:50 +0100
  Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-02-13 18:20 +0100

csiph-web