Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1333301 > unrolled thread

Re: [PATCH] net: cavium: liquidio: fix check for in progress flag

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] net: cavium: liquidio: fix check for in progress flag David Miller <davem@davemloft.net> - 2016-02-13 12:10 +0100

#1333301 — Re: [PATCH] net: cavium: liquidio: fix check for in progress flag

From: Colin King <colin.king@canonical.com>
Date: Fri,  5 Feb 2016 16:30:39 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> smatch detected a suspicious looking bitop condition:
> 
> drivers/net/ethernet/cavium/liquidio/lio_main.c:2529
>   handle_timestamp() warn: suspicious bitop condition
> 
> (skb_shinfo(skb)->tx_flags | SKBTX_IN_PROGRESS is always non-zero,
> so the logic is definitely not correct.  Use & to mask the correct
> bit.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

But this means one of the code paths was never tested...

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web