Re: [PATCH] net: cavium: liquidio: fix check for in progress flag

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: cavium: liquidio: fix check for in progress flag
Date	2016-02-13 12:10 +0100
Message-ID	<r1Gfn-3Vl-5@gated-at.bofh.it> (permalink)
References	<qYRAm-2Gm-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Fri,  5 Feb 2016 16:30:39 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> smatch detected a suspicious looking bitop condition:
> 
> drivers/net/ethernet/cavium/liquidio/lio_main.c:2529
>   handle_timestamp() warn: suspicious bitop condition
> 
> (skb_shinfo(skb)->tx_flags | SKBTX_IN_PROGRESS is always non-zero,
> so the logic is definitely not correct.  Use & to mask the correct
> bit.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

But this means one of the code paths was never tested...

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] net: cavium: liquidio: fix check for in progress flag David Miller <davem@davemloft.net> - 2016-02-13 12:10 +0100

csiph-web