Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332178 > unrolled thread

[PATCH] Revert "mmc: block: don't use parameter prefix if built as module"

Back to article view | Back to linux.kernel

Contents

  [PATCH] Revert "mmc: block: don't use parameter prefix if built as module" Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-11 17:00 +0100
    Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-11 17:00 +0100
      Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" John Stultz <john.stultz@linaro.org> - 2016-02-11 23:00 +0100
    Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" Greg KH <gregkh@linuxfoundation.org> - 2016-02-11 18:20 +0100
      Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-12 11:10 +0100
        Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" Greg KH <gregkh@linuxfoundation.org> - 2016-02-12 17:40 +0100

#1332178 — [PATCH] Revert "mmc: block: don't use parameter prefix if built as module"

This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503.

Revert this change as it causes a sysfs path to change and therefore
introduces and ABI regression. More precisely Android's vold is not being
able to access /sys/module/mmcblk/parameters/perdev_minors any more, since
the path becomes changed to: "/sys/module/mmc_block/..."

Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as
module")
Reported-by: John Stultz <john.stultz@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/mmc/card/block.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 951641a..fe207e5 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -47,13 +47,10 @@
 #include "queue.h"
 
 MODULE_ALIAS("mmc:block");
-
-#ifdef KERNEL
 #ifdef MODULE_PARAM_PREFIX
 #undef MODULE_PARAM_PREFIX
 #endif
 #define MODULE_PARAM_PREFIX "mmcblk."
-#endif
 
 #define INAND_CMD38_ARG_EXT_CSD  113
 #define INAND_CMD38_ARG_ERASE    0x00
-- 
1.9.1

[toc] | [next] | [standalone]

#1332181 — Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built as module"

On 11 February 2016 at 16:54, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503.
>
> Revert this change as it causes a sysfs path to change and therefore
> introduces and ABI regression. More precisely Android's vold is not being
> able to access /sys/module/mmcblk/parameters/perdev_minors any more, since
> the path becomes changed to: "/sys/module/mmc_block/..."
>
> Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as
> module")
> Reported-by: John Stultz <john.stultz@linaro.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

John, I noticed your regression report. Thanks!

I decided to send this patch and I have already queued it for fixes.

Sorry for not thinking clear when I applied the earlier patch.

Kind regards
Uffe

> ---
>  drivers/mmc/card/block.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 951641a..fe207e5 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -47,13 +47,10 @@
>  #include "queue.h"
>
>  MODULE_ALIAS("mmc:block");
> -
> -#ifdef KERNEL
>  #ifdef MODULE_PARAM_PREFIX
>  #undef MODULE_PARAM_PREFIX
>  #endif
>  #define MODULE_PARAM_PREFIX "mmcblk."
> -#endif
>
>  #define INAND_CMD38_ARG_EXT_CSD  113
>  #define INAND_CMD38_ARG_ERASE    0x00
> --
> 1.9.1
>

[toc] | [prev] | [next] | [standalone]

#1332397 — Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built as module"

On Thu, Feb 11, 2016 at 7:57 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 11 February 2016 at 16:54, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503.
>>
>> Revert this change as it causes a sysfs path to change and therefore
>> introduces and ABI regression. More precisely Android's vold is not being
>> able to access /sys/module/mmcblk/parameters/perdev_minors any more, since
>> the path becomes changed to: "/sys/module/mmc_block/..."
>>
>> Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as
>> module")
>> Reported-by: John Stultz <john.stultz@linaro.org>
>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> John, I noticed your regression report. Thanks!
>
> I decided to send this patch and I have already queued it for fixes.
>
> Sorry for not thinking clear when I applied the earlier patch.

Don't worry, those sorts of changes are subtle. I've seen a lot of
funny sysfs path breakage recently, but usually they are in paths that
are device specific (often related to the paths I think changed in the
dts - ie: lots of paths now have .../soc/... in them), so its not too
hard to just fix it for the device.

This one was more painful because it was generic path across all
devices. So I'm just glad to have caught it before the new behavior
became established and we'd be a bit stuck having to support both.

thanks
-john

[toc] | [prev] | [next] | [standalone]

#1332256 — Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built as module"

On Thu, Feb 11, 2016 at 04:54:11PM +0100, Ulf Hansson wrote:
> This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503.
> 
> Revert this change as it causes a sysfs path to change and therefore
> introduces and ABI regression. More precisely Android's vold is not being
> able to access /sys/module/mmcblk/parameters/perdev_minors any more, since
> the path becomes changed to: "/sys/module/mmc_block/..."
> 
> Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as
> module")
> Reported-by: John Stultz <john.stultz@linaro.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Please also add a "cc: stable..." tag to the patch so it gets picked up
in stable kernel releases.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1332656 — Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built as module"

On 11 February 2016 at 18:19, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Feb 11, 2016 at 04:54:11PM +0100, Ulf Hansson wrote:
>> This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503.
>>
>> Revert this change as it causes a sysfs path to change and therefore
>> introduces and ABI regression. More precisely Android's vold is not being
>> able to access /sys/module/mmcblk/parameters/perdev_minors any more, since
>> the path becomes changed to: "/sys/module/mmc_block/..."
>>
>> Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as
>> module")
>> Reported-by: John Stultz <john.stultz@linaro.org>
>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Please also add a "cc: stable..." tag to the patch so it gets picked up
> in stable kernel releases.

Doesn't the Fixes tag take care of that?

Kind regards
Uffe

[toc] | [prev] | [next] | [standalone]

#1332881 — Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built as module"

On Fri, Feb 12, 2016 at 11:06:03AM +0100, Ulf Hansson wrote:
> On 11 February 2016 at 18:19, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Feb 11, 2016 at 04:54:11PM +0100, Ulf Hansson wrote:
> >> This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503.
> >>
> >> Revert this change as it causes a sysfs path to change and therefore
> >> introduces and ABI regression. More precisely Android's vold is not being
> >> able to access /sys/module/mmcblk/parameters/perdev_minors any more, since
> >> the path becomes changed to: "/sys/module/mmc_block/..."
> >>
> >> Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as
> >> module")
> >> Reported-by: John Stultz <john.stultz@linaro.org>
> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >
> > Please also add a "cc: stable..." tag to the patch so it gets picked up
> > in stable kernel releases.
> 
> Doesn't the Fixes tag take care of that?

Not at all, never rely on that, please read
Documentation/stable_kernel_rules.txt for how to properly tag a patch
for a stable release.

Sometimes I get bored and look at patches with only a fixes: tag on them
to see how bad the maintainer is messing up and then do their work for
them, but that's rare these days...

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web