Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332881

Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built as module"

Show all headers | View raw

On Fri, Feb 12, 2016 at 11:06:03AM +0100, Ulf Hansson wrote:
> On 11 February 2016 at 18:19, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Feb 11, 2016 at 04:54:11PM +0100, Ulf Hansson wrote:
> >> This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503.
> >>
> >> Revert this change as it causes a sysfs path to change and therefore
> >> introduces and ABI regression. More precisely Android's vold is not being
> >> able to access /sys/module/mmcblk/parameters/perdev_minors any more, since
> >> the path becomes changed to: "/sys/module/mmc_block/..."
> >>
> >> Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as
> >> module")
> >> Reported-by: John Stultz <john.stultz@linaro.org>
> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >
> > Please also add a "cc: stable..." tag to the patch so it gets picked up
> > in stable kernel releases.
> 
> Doesn't the Fixes tag take care of that?

Not at all, never rely on that, please read
Documentation/stable_kernel_rules.txt for how to properly tag a patch
for a stable release.

Sometimes I get bored and look at patches with only a fixes: tag on them
to see how bad the maintainer is messing up and then do their work for
them, but that's rare these days...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "mmc: block: don't use parameter prefix if built as module" Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-11 17:00 +0100
  Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-11 17:00 +0100
    Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" John Stultz <john.stultz@linaro.org> - 2016-02-11 23:00 +0100
  Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" Greg KH <gregkh@linuxfoundation.org> - 2016-02-11 18:20 +0100
    Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-12 11:10 +0100
      Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built  as module" Greg KH <gregkh@linuxfoundation.org> - 2016-02-12 17:40 +0100

csiph-web