Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1330154 > unrolled thread

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

Started byMathieu OTHACEHE <m.othacehe@gmail.com>
First post2016-02-09 13:20 +0100
Last post2016-02-10 07:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] tty: add Moxa Smartio MUE serial driver Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-02-09 13:20 +0100
    Re: [PATCH] tty: add Moxa Smartio MUE serial driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-10 07:40 +0100

#1330154 — Re: [PATCH] tty: add Moxa Smartio MUE serial driver

FromMathieu OTHACEHE <m.othacehe@gmail.com>
Date2016-02-09 13:20 +0100
SubjectRe: [PATCH] tty: add Moxa Smartio MUE serial driver
Message-ID<r0fqX-3Sj-39@gated-at.bofh.it>
> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In
> which case why not to use 8250_core.c / 8250_port.c and entire 8250/
> infrastructure?

Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie.
The mxser driver has been cleaned up and integrated to mainline a long time ago (drivers/tty/mxser.c).
I'm trying to do the same thing with the mxupcie driver.

mxser and mxupcie are quite similar, maybe both should use 8250 infrastructure and not
have independant drivers ?

Mathieu

[toc] | [next] | [standalone]


#1330922

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2016-02-10 07:40 +0100
Message-ID<r0wBr-72V-5@gated-at.bofh.it>
In reply to#1330154
On Tue, Feb 9, 2016 at 2:10 PM, Mathieu OTHACEHE <m.othacehe@gmail.com> wrote:
>> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In
>> which case why not to use 8250_core.c / 8250_port.c and entire 8250/
>> infrastructure?
>
> Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie.
> The mxser driver has been cleaned up and integrated to mainline a long time ago (drivers/tty/mxser.c).
> I'm trying to do the same thing with the mxupcie driver.
>
> mxser and mxupcie are quite similar, maybe both should use 8250 infrastructure and not
> have independant drivers ?

Might be. Though for new driver it would be much easier to do.
After that someone might move the existing driver.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web