Re: [PATCH] tty: add Moxa Smartio MUE serial driver

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tty: add Moxa Smartio MUE serial driver
Date	2016-02-10 07:40 +0100
Message-ID	<r0wBr-72V-5@gated-at.bofh.it> (permalink)
References	<qXtqp-8iB-1@gated-at.bofh.it> <qZWHE-7Fq-37@gated-at.bofh.it> <r0fqX-3Sj-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 9, 2016 at 2:10 PM, Mathieu OTHACEHE <m.othacehe@gmail.com> wrote:
>> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In
>> which case why not to use 8250_core.c / 8250_port.c and entire 8250/
>> infrastructure?
>
> Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie.
> The mxser driver has been cleaned up and integrated to mainline a long time ago (drivers/tty/mxser.c).
> I'm trying to do the same thing with the mxupcie driver.
>
> mxser and mxupcie are quite similar, maybe both should use 8250 infrastructure and not
> have independant drivers ?

Might be. Though for new driver it would be much easier to do.
After that someone might move the existing driver.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] tty: add Moxa Smartio MUE serial driver Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-02-09 13:20 +0100
  Re: [PATCH] tty: add Moxa Smartio MUE serial driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-10 07:40 +0100

csiph-web