Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329473 > unrolled thread

Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from  dell_smbios_send_request() Darren Hart <dvhart@infradead.org> - 2016-02-08 19:50 +0100
    Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from  dell_smbios_send_request() Michał Kępień <kernel@kempniu.pl> - 2016-02-09 14:30 +0100
      Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from  dell_smbios_send_request() Darren Hart <dvhart@infradead.org> - 2016-02-09 18:00 +0100
        Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from  dell_smbios_send_request() Michał Kępień <kernel@kempniu.pl> - 2016-02-09 18:40 +0100

#1329473 — Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

On Fri, Jan 22, 2016 at 03:27:19PM +0100, Michał Kępień wrote:
> An SMBIOS buffer pointer does not need to be returned by
> dell_smbios_send_request(), because SMBIOS call results are stored in
> the buffer passed as input.

This should come before 6/16, update the commit message to reflect the module
exported buffer (not the one passed as input), or possibly just merge this patch
and 6/16 as correcting the use of SMBIOS buffer within the module.

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [next] | [standalone]

#1330227

> > An SMBIOS buffer pointer does not need to be returned by
> > dell_smbios_send_request(), because SMBIOS call results are stored in
> > the buffer passed as input.
> 
> This should come before 6/16, update the commit message to reflect the module
> exported buffer (not the one passed as input), or possibly just merge this patch
> and 6/16 as correcting the use of SMBIOS buffer within the module.

I have only now noticed that I phrased the commit message for this patch
rather unfortunately as it inappropriately conveyed my reasoning.  What
I meant by "the buffer passed as input" was not "the buffer passed as an
argument to dell_smbios_send_request()", but rather "the buffer passed
to the SMI handler".  In other words, there is no reason to return a
buffer from dell_smbios_send_request(), because each caller will simply
find their output in the same buffer they used to provide input (no
matter whether the latter is passed as a function argument or accessed
using a module-wide variable).

Anyway, as even the above explanation is hardly a stellar demonstration
of clarity, I believe your idea of resolving this issue may simply be
the best one, thanks.

-- 
Best regards,
Michał Kępień

[toc] | [prev] | [next] | [standalone]

#1330474

On Tue, Feb 09, 2016 at 02:27:36PM +0100, Michał Kępień wrote:
> > > An SMBIOS buffer pointer does not need to be returned by
> > > dell_smbios_send_request(), because SMBIOS call results are stored in
> > > the buffer passed as input.
> > 
> > This should come before 6/16, update the commit message to reflect the module
> > exported buffer (not the one passed as input), or possibly just merge this patch
> > and 6/16 as correcting the use of SMBIOS buffer within the module.
> 
> I have only now noticed that I phrased the commit message for this patch
> rather unfortunately as it inappropriately conveyed my reasoning.  What
> I meant by "the buffer passed as input" was not "the buffer passed as an
> argument to dell_smbios_send_request()", but rather "the buffer passed
> to the SMI handler".  In other words, there is no reason to return a
> buffer from dell_smbios_send_request(), because each caller will simply
> find their output in the same buffer they used to provide input (no
> matter whether the latter is passed as a function argument or accessed
> using a module-wide variable).
> 
> Anyway, as even the above explanation is hardly a stellar demonstration
> of clarity, I believe your idea of resolving this issue may simply be
> the best one, thanks.

In my tree, I reworded this as:

    dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

    An SMBIOS buffer pointer does not need to be returned by
    dell_smbios_send_request(), because SMBIOS call results are stored in
    the buffer exported by the module.

Is that acceptable?

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1330529

> > > > An SMBIOS buffer pointer does not need to be returned by
> > > > dell_smbios_send_request(), because SMBIOS call results are stored in
> > > > the buffer passed as input.
> In my tree, I reworded this as:
> 
>     dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()
> 
>     An SMBIOS buffer pointer does not need to be returned by
>     dell_smbios_send_request(), because SMBIOS call results are stored in
>     the buffer exported by the module.
> 
> Is that acceptable?

Sure, thanks.  I saw the edited commit message in your tree before
sending my previous message and I liked it.

-- 
Best regards,
Michał Kępień

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web