Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

From	Michał Kępień <kernel@kempniu.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()
Date	2016-02-09 18:40 +0100
Message-ID	<r0kqE-7hS-65@gated-at.bofh.it> (permalink)
References	<qTKSR-5dr-7@gated-at.bofh.it> <qTKSS-5dr-21@gated-at.bofh.it> <qZZ2O-HE-9@gated-at.bofh.it> <r0gwF-4Ai-9@gated-at.bofh.it> <r0jNW-6Mt-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > > > An SMBIOS buffer pointer does not need to be returned by
> > > > dell_smbios_send_request(), because SMBIOS call results are stored in
> > > > the buffer passed as input.
> In my tree, I reworded this as:
> 
>     dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()
> 
>     An SMBIOS buffer pointer does not need to be returned by
>     dell_smbios_send_request(), because SMBIOS call results are stored in
>     the buffer exported by the module.
> 
> Is that acceptable?

Sure, thanks.  I saw the edited commit message in your tree before
sending my previous message and I liked it.

-- 
Best regards,
Michał Kępień

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from  dell_smbios_send_request() Michał Kępień <kernel@kempniu.pl> - 2016-02-09 14:30 +0100
  Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from  dell_smbios_send_request() Darren Hart <dvhart@infradead.org> - 2016-02-09 18:00 +0100
    Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from  dell_smbios_send_request() Michał Kępień <kernel@kempniu.pl> - 2016-02-09 18:40 +0100

csiph-web