Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329260 > unrolled thread

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] tty: add Moxa Smartio MUE serial driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-08 17:20 +0100
    Re: [PATCH] tty: add Moxa Smartio MUE serial driver Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-02-09 13:20 +0100
      Re: [PATCH] tty: add Moxa Smartio MUE serial driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-10 07:40 +0100

#1329260 — Re: [PATCH] tty: add Moxa Smartio MUE serial driver

On Mon, Feb 1, 2016 at 10:34 PM, Mathieu OTHACEHE <m.othacehe@gmail.com> wrote:
> Add a driver which supports:
>
> - CP-102E: 2 ports RS232 PCIE card
> - CP-102EL: 2 ports RS232 PCIE card
> - CP-132EL: 2 ports RS422/485 PCIE card
> - CP-114EL: 4 ports RS232/422/485 PCIE card
> - CP-104EL-A: 4 ports RS232 PCIE card
> - CP-168EL-A: 8 ports RS232 PCIE card
> - CP-118EL-A: 8 ports RS232/422/485 PCIE card
> - CP-118E-A: 8 ports RS422/485 PCIE card
> - CP-138E-A: 8 ports RS422/485 PCIE card
> - CP-134EL-A: 4 ports RS422/485 PCIE card
> - CP-116E-A (A): 8 ports RS232/422/485 PCIE card
> - CP-116E-A (B): 8 ports RS232/422/485 PCIE card
>
> This driver is based on 1.16.7 GPL MOXA driver written by Eric Lo
> and available on MOXA website. The original driver was based on
> Linux serial driver.
>
> Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
> ---
>
> Hi,
>
> Here is a new driver for MOXA Smartio MUE cards. It is based
> on the vendor driver available on MOXA website and on the
> mainline mxser driver.
>
> I was able to test it on a CP-168EL-A card on PC. Some of the
> cards (118E-A, 138E-A, 134EL-A, 116E-A-A et 116E-A-B) have
> a CPLD module programmable via GPIO.
> For now, I dropped all the code related to CPLD/GPIO because I
> can't test it on my card.
>
> Mathieu

I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In
which case why not to use 8250_core.c / 8250_port.c and entire 8250/
infrastructure?

-- 
With Best Regards,
Andy Shevchenko

[toc] | [next] | [standalone]

#1330154

> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In
> which case why not to use 8250_core.c / 8250_port.c and entire 8250/
> infrastructure?

Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie.
The mxser driver has been cleaned up and integrated to mainline a long time ago (drivers/tty/mxser.c).
I'm trying to do the same thing with the mxupcie driver.

mxser and mxupcie are quite similar, maybe both should use 8250 infrastructure and not
have independant drivers ?

Mathieu

[toc] | [prev] | [next] | [standalone]

#1330922

On Tue, Feb 9, 2016 at 2:10 PM, Mathieu OTHACEHE <m.othacehe@gmail.com> wrote:
>> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In
>> which case why not to use 8250_core.c / 8250_port.c and entire 8250/
>> infrastructure?
>
> Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie.
> The mxser driver has been cleaned up and integrated to mainline a long time ago (drivers/tty/mxser.c).
> I'm trying to do the same thing with the mxupcie driver.
>
> mxser and mxupcie are quite similar, maybe both should use 8250 infrastructure and not
> have independant drivers ?

Might be. Though for new driver it would be much easier to do.
After that someone might move the existing driver.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web