Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331336 > unrolled thread

Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every jump to again

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every  jump to again Petr Mladek <pmladek@suse.com> - 2016-02-10 18:00 +0100
    Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every  jump to again Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-11 09:10 +0100

#1331336 — Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every jump to again

On Sat 2016-01-23 17:15:11, Sergey Senozhatsky wrote:
> Every jump to `again' label will call console_cont_flush(),
> which is not really something big -- it just adds one extra
> raw_spin_lock_irqsave/raw_spin_unlock_irqrestore. However, to
> keep the previous behaviour we can call console_cont_flush()
> only when `retry' is false -- which happens once, all jumps
> to `again' label have `retry' set to true.

The patch is correct and restores the original behavior, so

Reviewed-by: Petr Mladek <pmladek@suse.com>

But I would personally omit it. We see the cont buffer earlier
without this patch.

Best Regards,
Petr

PS: I will review the other patches tomorrow.

[toc] | [next] | [standalone]

#1331718

Hello Petr,

On (02/10/16 17:58), Petr Mladek wrote:
> On Sat 2016-01-23 17:15:11, Sergey Senozhatsky wrote:
> > Every jump to `again' label will call console_cont_flush(),
> > which is not really something big -- it just adds one extra
> > raw_spin_lock_irqsave/raw_spin_unlock_irqrestore. However, to
> > keep the previous behaviour we can call console_cont_flush()
> > only when `retry' is false -- which happens once, all jumps
> > to `again' label have `retry' set to true.
> 
> The patch is correct and restores the original behavior, so
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> 
> But I would personally omit it. We see the cont buffer earlier
> without this patch.

ok.

> PS: I will review the other patches tomorrow.

thanks.

	-ss

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web