Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every jump to again

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every jump to again
Date	2016-02-10 18:00 +0100
Message-ID	<r0Ght-4Nm-41@gated-at.bofh.it> (permalink)
References	<qU1Al-8nr-3@gated-at.bofh.it> <qU1Al-8nr-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat 2016-01-23 17:15:11, Sergey Senozhatsky wrote:
> Every jump to `again' label will call console_cont_flush(),
> which is not really something big -- it just adds one extra
> raw_spin_lock_irqsave/raw_spin_unlock_irqrestore. However, to
> keep the previous behaviour we can call console_cont_flush()
> only when `retry' is false -- which happens once, all jumps
> to `again' label have `retry' set to true.

The patch is correct and restores the original behavior, so

Reviewed-by: Petr Mladek <pmladek@suse.com>

But I would personally omit it. We see the cont buffer earlier
without this patch.

Best Regards,
Petr

PS: I will review the other patches tomorrow.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every  jump to again Petr Mladek <pmladek@suse.com> - 2016-02-10 18:00 +0100
  Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every  jump to again Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-11 09:10 +0100

csiph-web