Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1331363 > unrolled thread

Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

Started by"Martin K. Petersen" <martin.petersen@oracle.com>
First post2016-02-10 18:40 +0100
Last post2016-02-11 10:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32() "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-02-10 18:40 +0100
    RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32() Anil Gurumurthy <Anil.Gurumurthy@qlogic.com> - 2016-02-11 10:00 +0100

#1331363 — Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

From"Martin K. Petersen" <martin.petersen@oracle.com>
Date2016-02-10 18:40 +0100
SubjectRe: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()
Message-ID<r0GUb-5nr-17@gated-at.bofh.it>
>>>>> "Denys" == Denys Vlasenko <dvlasenk@redhat.com> writes:

Denys> __bfa_trc32() is very similar, so it is uninlined too.  However,
Denys> it appears to be unused, therefore this patch ifdefs it out.

Why don't we just drop it?

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [next] | [standalone]


#1331738

FromAnil Gurumurthy <Anil.Gurumurthy@qlogic.com>
Date2016-02-11 10:00 +0100
Message-ID<r0Vgu-6mz-1@gated-at.bofh.it>
In reply to#1331363
You could remove the __bfa_trc32() routine

Thanks,
Acked-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>

-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com] 
Sent: 10 February 2016 22:59
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: James Bottomley <JBottomley@Parallels.com>; Fabian Frederick <fabf@skynet.be>; Anil Gurumurthy <Anil.Gurumurthy@qlogic.com>; Christoph Hellwig <hch@lst.de>; Guenter Roeck <linux@roeck-us.net>; Ben Hutchings <ben@decadent.org.uk>; linux-kernel <linux-kernel@vger.kernel.org>; linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

>>>>> "Denys" == Denys Vlasenko <dvlasenk@redhat.com> writes:

Denys> __bfa_trc32() is very similar, so it is uninlined too.  However, 
Denys> it appears to be unused, therefore this patch ifdefs it out.

Why don't we just drop it?

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web