RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

From	Anil Gurumurthy <Anil.Gurumurthy@qlogic.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()
Date	2016-02-11 10:00 +0100
Message-ID	<r0Vgu-6mz-1@gated-at.bofh.it> (permalink)
References	<qYzar-74b-29@gated-at.bofh.it> <r0GUb-5nr-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

You could remove the __bfa_trc32() routine

Thanks,
Acked-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>

-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com] 
Sent: 10 February 2016 22:59
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: James Bottomley <JBottomley@Parallels.com>; Fabian Frederick <fabf@skynet.be>; Anil Gurumurthy <Anil.Gurumurthy@qlogic.com>; Christoph Hellwig <hch@lst.de>; Guenter Roeck <linux@roeck-us.net>; Ben Hutchings <ben@decadent.org.uk>; linux-kernel <linux-kernel@vger.kernel.org>; linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

>>>>> "Denys" == Denys Vlasenko <dvlasenk@redhat.com> writes:

Denys> __bfa_trc32() is very similar, so it is uninlined too.  However, 
Denys> it appears to be unused, therefore this patch ifdefs it out.

Why don't we just drop it?

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32() "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-02-10 18:40 +0100
  RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32() Anil Gurumurthy <Anil.Gurumurthy@qlogic.com> - 2016-02-11 10:00 +0100

csiph-web