Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1330513 > unrolled thread
| Started by | Laxman Dewangan <ldewangan@nvidia.com> |
|---|---|
| First post | 2016-02-09 18:40 +0100 |
| Last post | 2016-02-15 00:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-09 18:40 +0100
Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Lee Jones <lee.jones@linaro.org> - 2016-02-10 17:10 +0100
Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-15 00:50 +0100
| From | Laxman Dewangan <ldewangan@nvidia.com> |
|---|---|
| Date | 2016-02-09 18:40 +0100 |
| Subject | [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client |
| Message-ID | <r0kqC-7hS-7@gated-at.bofh.it> |
There is different RTC I2C address for RTC block in MAX77686. Driver is creating dummy i2c client for this address to access the register of this IP block. As there is no call to i2c_get_clientdata() for rtc_i2c client, there is no need to store pointer and hence removing the call to set client data for rtc i2c client. Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> CC: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- This is new in this series based on review comment from V1. Changes from V2: - Rephrase description. - Added reviewed by. Changes from V3: - None, become 5th on series. Changes from V4: None Changes from V5: None Changes from V6: Make this as 4th of series as regmap change applied independently. drivers/mfd/max77686.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index d959ebb..bda6fd7 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -277,7 +277,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c, "Failed to allocate I2C device for RTC\n"); return -ENODEV; } - i2c_set_clientdata(max77686->rtc, max77686); max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc, -- 2.1.4
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-02-10 17:10 +0100 |
| Subject | Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client |
| Message-ID | <r0Fv5-4sd-39@gated-at.bofh.it> |
| In reply to | #1330513 |
On Tue, 09 Feb 2016, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no call to i2c_get_clientdata() for rtc_i2c client, > there is no need to store pointer and hence removing the call > to set client data for rtc i2c client. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > CC: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Tested-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > This is new in this series based on review comment from V1. > > Changes from V2: > - Rephrase description. > - Added reviewed by. > > Changes from V3: > - None, become 5th on series. > > Changes from V4: > None > > Changes from V5: > None > > Changes from V6: > Make this as 4th of series as regmap change applied independently. > > drivers/mfd/max77686.c | 1 - > 1 file changed, 1 deletion(-) Appart from the subject line being wrong: Acked-by: Lee Jones <lee.jones@linaro.org> [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-02-15 00:50 +0100 |
| Subject | Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client |
| Message-ID | <r2eAs-1fL-63@gated-at.bofh.it> |
| In reply to | #1330513 |
On 10.02.2016 02:26, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no call to i2c_get_clientdata() for rtc_i2c client, > there is no need to store pointer and hence removing the call > to set client data for rtc i2c client. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > CC: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Tested-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > FWIW, on max77686: Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web