Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client
Date	2016-02-15 00:50 +0100
Message-ID	<r2eAs-1fL-63@gated-at.bofh.it> (permalink)
References	<r0kqC-7hS-9@gated-at.bofh.it> <r0kqC-7hS-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10.02.2016 02:26, Laxman Dewangan wrote:
> There is different RTC I2C address for RTC block in MAX77686.
> Driver is creating dummy i2c client for this address to access
> the register of this IP block.
> 
> As there is no call to i2c_get_clientdata() for rtc_i2c client,
> there is no need to store pointer and hence removing the call
> to set client data for rtc i2c client.
> 
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

FWIW, on max77686:
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-09 18:40 +0100
  Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc  i2c client Lee Jones <lee.jones@linaro.org> - 2016-02-10 17:10 +0100
  Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc  i2c client Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-15 00:50 +0100

csiph-web