Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1278906 > unrolled thread

[PATCH 1/3] perf report: Show error message when processing sample fails

Started byNamhyung Kim <namhyung@kernel.org>
First post2015-11-27 18:40 +0100
Last post2015-11-29 09:00 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/3] perf report: Show error message when processing sample fails Namhyung Kim <namhyung@kernel.org> - 2015-11-27 18:40 +0100
    Re: [PATCH 1/3] perf report: Show error message when processing  sample fails Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-27 21:00 +0100
      Re: [PATCH 1/3] perf report: Show error message when processing  sample fails Namhyung Kim <namhyung@kernel.org> - 2015-11-28 03:00 +0100
    Re: [PATCH 1/3] perf report: Show error message when processing  sample fails Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-27 21:00 +0100
    [tip:perf/core] perf report:   Show error message when processing sample fails tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-11-29 09:00 +0100

#1278906 — [PATCH 1/3] perf report: Show error message when processing sample fails

FromNamhyung Kim <namhyung@kernel.org>
Date2015-11-27 18:40 +0100
Subject[PATCH 1/3] perf report: Show error message when processing sample fails
Message-ID<qzva1-5TV-11@gated-at.bofh.it>
Currently when perf fails to process samples for some reason, it doesn't
show any message about the failure.  This is very inconvenient for users
especially on TUI as screen is reset after the failure.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-report.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 8a9c6908f54e..af5db885ea9c 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep)
 	if (rep->cpu_list) {
 		ret = perf_session__cpu_bitmap(session, rep->cpu_list,
 					       rep->cpu_bitmap);
-		if (ret)
+		if (ret) {
+			ui__error("failed to set cpu bitmap\n");
 			return ret;
+		}
 	}
 
 	if (rep->show_threads)
 		perf_read_values_init(&rep->show_threads_values);
 
 	ret = report__setup_sample_type(rep);
-	if (ret)
+	if (ret) {
+		/* report__setup_sample_type() already showed error message */
 		return ret;
+	}
 
 	ret = perf_session__process_events(session);
-	if (ret)
+	if (ret) {
+		ui__error("failed to process sample\n");
 		return ret;
+	}
 
 	report__warn_kptr_restrict(rep);
 
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1278936 — Re: [PATCH 1/3] perf report: Show error message when processing sample fails

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-11-27 21:00 +0100
SubjectRe: [PATCH 1/3] perf report: Show error message when processing sample fails
Message-ID<qzxlw-79e-9@gated-at.bofh.it>
In reply to#1278906
Em Fri, Nov 27, 2015 at 04:56:27PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sat, Nov 28, 2015 at 02:32:37AM +0900, Namhyung Kim escreveu:
> > Currently when perf fails to process samples for some reason, it doesn't
> > show any message about the failure.  This is very inconvenient for users
> > especially on TUI as screen is reset after the failure.
> > 
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Ah, I added a :

Reported-by: Ingo Molnar <mingo@kernel.org>

As this was due to those messages from Ingo, right?

- Arnaldo

> > ---
> >  tools/perf/builtin-report.c | 12 +++++++++---
> >  1 file changed, 9 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > index 8a9c6908f54e..af5db885ea9c 100644
> > --- a/tools/perf/builtin-report.c
> > +++ b/tools/perf/builtin-report.c
> > @@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep)
> >  	if (rep->cpu_list) {
> >  		ret = perf_session__cpu_bitmap(session, rep->cpu_list,
> >  					       rep->cpu_bitmap);
> > -		if (ret)
> > +		if (ret) {
> > +			ui__error("failed to set cpu bitmap\n");
> 
> Why? See below.
> 
> >  			return ret;
> > +		}
> >  	}
> >  
> >  	if (rep->show_threads)
> >  		perf_read_values_init(&rep->show_threads_values);
> >  
> >  	ret = report__setup_sample_type(rep);
> > -	if (ret)
> > +	if (ret) {
> > +		/* report__setup_sample_type() already showed error message */
> >  		return ret;
> > +	}
> >  
> >  	ret = perf_session__process_events(session);
> > -	if (ret)
> > +	if (ret) {
> > +		ui__error("failed to process sample\n");
> >  		return ret;
> > +	}
> 
> I'm applying this because it removes the potential flash, but would be
> good to have the reason for this failure shown to the user.
> 
> - Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1279068 — Re: [PATCH 1/3] perf report: Show error message when processing sample fails

FromNamhyung Kim <namhyung@kernel.org>
Date2015-11-28 03:00 +0100
SubjectRe: [PATCH 1/3] perf report: Show error message when processing sample fails
Message-ID<qzCXT-2h2-1@gated-at.bofh.it>
In reply to#1278936
Hi Arnaldo,

On Fri, Nov 27, 2015 at 04:57:21PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Nov 27, 2015 at 04:56:27PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Sat, Nov 28, 2015 at 02:32:37AM +0900, Namhyung Kim escreveu:
> > > Currently when perf fails to process samples for some reason, it doesn't
> > > show any message about the failure.  This is very inconvenient for users
> > > especially on TUI as screen is reset after the failure.
> > > 
> > > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> 
> Ah, I added a :
> 
> Reported-by: Ingo Molnar <mingo@kernel.org>
> 
> As this was due to those messages from Ingo, right?

Right.


> 
> > > ---
> > >  tools/perf/builtin-report.c | 12 +++++++++---
> > >  1 file changed, 9 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > > index 8a9c6908f54e..af5db885ea9c 100644
> > > --- a/tools/perf/builtin-report.c
> > > +++ b/tools/perf/builtin-report.c
> > > @@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep)
> > >  	if (rep->cpu_list) {
> > >  		ret = perf_session__cpu_bitmap(session, rep->cpu_list,
> > >  					       rep->cpu_bitmap);
> > > -		if (ret)
> > > +		if (ret) {
> > > +			ui__error("failed to set cpu bitmap\n");
> > 
> > Why? See below.
> > 
> > >  			return ret;
> > > +		}
> > >  	}
> > >  
> > >  	if (rep->show_threads)
> > >  		perf_read_values_init(&rep->show_threads_values);
> > >  
> > >  	ret = report__setup_sample_type(rep);
> > > -	if (ret)
> > > +	if (ret) {
> > > +		/* report__setup_sample_type() already showed error message */
> > >  		return ret;
> > > +	}
> > >  
> > >  	ret = perf_session__process_events(session);
> > > -	if (ret)
> > > +	if (ret) {
> > > +		ui__error("failed to process sample\n");
> > >  		return ret;
> > > +	}
> > 
> > I'm applying this because it removes the potential flash, but would be
> > good to have the reason for this failure shown to the user.

Yes, but at least the last error/warning will be shown in the bottom.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1278937 — Re: [PATCH 1/3] perf report: Show error message when processing sample fails

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-11-27 21:00 +0100
SubjectRe: [PATCH 1/3] perf report: Show error message when processing sample fails
Message-ID<qzxlw-79e-11@gated-at.bofh.it>
In reply to#1278906
Em Sat, Nov 28, 2015 at 02:32:37AM +0900, Namhyung Kim escreveu:
> Currently when perf fails to process samples for some reason, it doesn't
> show any message about the failure.  This is very inconvenient for users
> especially on TUI as screen is reset after the failure.
> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/builtin-report.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 8a9c6908f54e..af5db885ea9c 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep)
>  	if (rep->cpu_list) {
>  		ret = perf_session__cpu_bitmap(session, rep->cpu_list,
>  					       rep->cpu_bitmap);
> -		if (ret)
> +		if (ret) {
> +			ui__error("failed to set cpu bitmap\n");

Why? See below.

>  			return ret;
> +		}
>  	}
>  
>  	if (rep->show_threads)
>  		perf_read_values_init(&rep->show_threads_values);
>  
>  	ret = report__setup_sample_type(rep);
> -	if (ret)
> +	if (ret) {
> +		/* report__setup_sample_type() already showed error message */
>  		return ret;
> +	}
>  
>  	ret = perf_session__process_events(session);
> -	if (ret)
> +	if (ret) {
> +		ui__error("failed to process sample\n");
>  		return ret;
> +	}

I'm applying this because it removes the potential flash, but would be
good to have the reason for this failure shown to the user.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1279285 — [tip:perf/core] perf report: Show error message when processing sample fails

Fromtip-bot for Namhyung Kim <tipbot@zytor.com>
Date2015-11-29 09:00 +0100
Subject[tip:perf/core] perf report: Show error message when processing sample fails
Message-ID<qA53Q-3nY-15@gated-at.bofh.it>
In reply to#1278906
Commit-ID:  25b1606be1a910a63a23c3d1006581c9aad4e6e3
Gitweb:     http://git.kernel.org/tip/25b1606be1a910a63a23c3d1006581c9aad4e6e3
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Sat, 28 Nov 2015 02:32:37 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 27 Nov 2015 16:56:32 -0300

perf report: Show error message when processing sample fails

Currently when perf fails to process samples for some reason, it doesn't
show any message about the failure.  This is very inconvenient for users
especially on TUI as screen is reset after the failure.

Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1448645559-31167-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-report.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 8a9c690..af5db88 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep)
 	if (rep->cpu_list) {
 		ret = perf_session__cpu_bitmap(session, rep->cpu_list,
 					       rep->cpu_bitmap);
-		if (ret)
+		if (ret) {
+			ui__error("failed to set cpu bitmap\n");
 			return ret;
+		}
 	}
 
 	if (rep->show_threads)
 		perf_read_values_init(&rep->show_threads_values);
 
 	ret = report__setup_sample_type(rep);
-	if (ret)
+	if (ret) {
+		/* report__setup_sample_type() already showed error message */
 		return ret;
+	}
 
 	ret = perf_session__process_events(session);
-	if (ret)
+	if (ret) {
+		ui__error("failed to process sample\n");
 		return ret;
+	}
 
 	report__warn_kptr_restrict(rep);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web