Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1278906

[PATCH 1/3] perf report: Show error message when processing sample fails

Show all headers | View raw

Currently when perf fails to process samples for some reason, it doesn't
show any message about the failure.  This is very inconvenient for users
especially on TUI as screen is reset after the failure.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-report.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 8a9c6908f54e..af5db885ea9c 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep)
 	if (rep->cpu_list) {
 		ret = perf_session__cpu_bitmap(session, rep->cpu_list,
 					       rep->cpu_bitmap);
-		if (ret)
+		if (ret) {
+			ui__error("failed to set cpu bitmap\n");
 			return ret;
+		}
 	}
 
 	if (rep->show_threads)
 		perf_read_values_init(&rep->show_threads_values);
 
 	ret = report__setup_sample_type(rep);
-	if (ret)
+	if (ret) {
+		/* report__setup_sample_type() already showed error message */
 		return ret;
+	}
 
 	ret = perf_session__process_events(session);
-	if (ret)
+	if (ret) {
+		ui__error("failed to process sample\n");
 		return ret;
+	}
 
 	report__warn_kptr_restrict(rep);
 
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] perf report: Show error message when processing sample fails Namhyung Kim <namhyung@kernel.org> - 2015-11-27 18:40 +0100
  Re: [PATCH 1/3] perf report: Show error message when processing  sample fails Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-27 21:00 +0100
    Re: [PATCH 1/3] perf report: Show error message when processing  sample fails Namhyung Kim <namhyung@kernel.org> - 2015-11-28 03:00 +0100
  Re: [PATCH 1/3] perf report: Show error message when processing  sample fails Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-27 21:00 +0100
  [tip:perf/core] perf report:   Show error message when processing sample fails tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-11-29 09:00 +0100

csiph-web