Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1277387 > unrolled thread
| Started by | Geliang Tang <geliangtang@163.com> |
|---|---|
| First post | 2015-11-25 14:20 +0100 |
| Last post | 2015-11-26 16:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON() Geliang Tang <geliangtang@163.com> - 2015-11-25 14:20 +0100
Re: [PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON() "Sinclair Yeh" <syeh@vmware.com> - 2015-11-25 16:50 +0100
Re: [PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON() Thomas Hellstrom <thellstrom@vmware.com> - 2015-11-26 16:00 +0100
| From | Geliang Tang <geliangtang@163.com> |
|---|---|
| Date | 2015-11-25 14:20 +0100 |
| Subject | [PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON() |
| Message-ID | <qyI9k-6MK-23@gated-at.bofh.it> |
WARN_ON() takes a condition rather than a format string. This patch
converted WARN_ON() to WARN() instead.
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
index a8baf5f..b6a0806 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
@@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
else if (ctx_id == SVGA3D_INVALID_ID)
ret = vmw_local_fifo_reserve(dev_priv, bytes);
else {
- WARN_ON("Command buffer has not been allocated.\n");
+ WARN(1, "Command buffer has not been allocated.\n");
ret = NULL;
}
if (IS_ERR_OR_NULL(ret)) {
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Sinclair Yeh" <syeh@vmware.com> |
|---|---|
| Date | 2015-11-25 16:50 +0100 |
| Message-ID | <qyKuu-8c2-11@gated-at.bofh.it> |
| In reply to | #1277387 |
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
On Wed, Nov 25, 2015 at 09:12:15PM +0800, Geliang Tang wrote:
> WARN_ON() takes a condition rather than a format string. This patch
> converted WARN_ON() to WARN() instead.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> index a8baf5f..b6a0806 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
> else if (ctx_id == SVGA3D_INVALID_ID)
> ret = vmw_local_fifo_reserve(dev_priv, bytes);
> else {
> - WARN_ON("Command buffer has not been allocated.\n");
> + WARN(1, "Command buffer has not been allocated.\n");
> ret = NULL;
> }
> if (IS_ERR_OR_NULL(ret)) {
> --
> 2.5.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Thomas Hellstrom <thellstrom@vmware.com> |
|---|---|
| Date | 2015-11-26 16:00 +0100 |
| Message-ID | <qz6bD-6xn-1@gated-at.bofh.it> |
| In reply to | #1277387 |
Thanks for reporting!
This fix was already reported by Dan Carpenter and has already been
queued in vmwgfx-fixes-4.4
/Thomas
On 11/25/2015 02:12 PM, Geliang Tang wrote:
> WARN_ON() takes a condition rather than a format string. This patch
> converted WARN_ON() to WARN() instead.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> index a8baf5f..b6a0806 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
> else if (ctx_id == SVGA3D_INVALID_ID)
> ret = vmw_local_fifo_reserve(dev_priv, bytes);
> else {
> - WARN_ON("Command buffer has not been allocated.\n");
> + WARN(1, "Command buffer has not been allocated.\n");
> ret = NULL;
> }
> if (IS_ERR_OR_NULL(ret)) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web