[PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON()

From	Geliang Tang <geliangtang@163.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON()
Date	2015-11-25 14:20 +0100
Message-ID	<qyI9k-6MK-23@gated-at.bofh.it> (permalink)
References	<qyI9j-6MK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

WARN_ON() takes a condition rather than a format string. This patch
converted WARN_ON() to WARN() instead.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
index a8baf5f..b6a0806 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
@@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
 	else if (ctx_id == SVGA3D_INVALID_ID)
 		ret = vmw_local_fifo_reserve(dev_priv, bytes);
 	else {
-		WARN_ON("Command buffer has not been allocated.\n");
+		WARN(1, "Command buffer has not been allocated.\n");
 		ret = NULL;
 	}
 	if (IS_ERR_OR_NULL(ret)) {
-- 
2.5.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON() Geliang Tang <geliangtang@163.com> - 2015-11-25 14:20 +0100
  Re: [PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON() "Sinclair Yeh" <syeh@vmware.com> - 2015-11-25 16:50 +0100
  Re: [PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON() Thomas Hellstrom <thellstrom@vmware.com> - 2015-11-26 16:00 +0100

csiph-web