Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1277350 > unrolled thread

Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC

Started byMark Brown <broonie@kernel.org>
First post2015-11-25 13:50 +0100
Last post2015-11-25 13:50 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio  internal DAC Mark Brown <broonie@kernel.org> - 2015-11-25 13:50 +0100

#1277350 — Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC

FromMark Brown <broonie@kernel.org>
Date2015-11-25 13:50 +0100
SubjectRe: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC
Message-ID<qyHGh-6l3-1@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:

> +	/* The mute state as set by alsa using the digital_mute callback */
> +	bool alsa_mute_state;
> +	/* The mute state as set by the userspace mute control */
> +	bool control_mute_state;
> +	/* The actual mute state is equal to an OR of the above */

Does the device *need* the digital mute to avoid noise?  If there's no
strong need for it then just don't bother which simplifies the code a
lot.

Otherwise this looks good.

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web