Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1277350

Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC
Date 2015-11-25 13:50 +0100
Message-ID <qyHGh-6l3-1@gated-at.bofh.it> (permalink)
References <qyHGh-6l3-3@gated-at.bofh.it> <qyHGh-6l3-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:

> +	/* The mute state as set by alsa using the digital_mute callback */
> +	bool alsa_mute_state;
> +	/* The mute state as set by the userspace mute control */
> +	bool control_mute_state;
> +	/* The actual mute state is equal to an OR of the above */

Does the device *need* the digital mute to avoid noise?  If there's no
strong need for it then just don't bother which simplifies the code a
lot.

Otherwise this looks good.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio  internal DAC Mark Brown <broonie@kernel.org> - 2015-11-25 13:50 +0100

csiph-web