Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1275640 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2015-11-23 18:00 +0100 |
| Last post | 2015-11-23 20:30 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module Arnd Bergmann <arnd@arndb.de> - 2015-11-23 18:00 +0100
Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module "Andrew F. Davis" <afd@ti.com> - 2015-11-23 18:20 +0100
Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module Arnd Bergmann <arnd@arndb.de> - 2015-11-23 20:30 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-11-23 18:00 +0100 |
| Subject | Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module |
| Message-ID | <qy2D9-4un-41@gated-at.bofh.it> |
On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote: > Separate out I2C functionality into a module. This fixes several small > issues and simplifies the driver initialization. > > Signed-off-by: Andrew F. Davis <afd@ti.com> That looks good to me overall, it should help with the randconfig warnings I've been seeing and makes the driver structured more logically. The one part I wonder about is whether the platform_driver portion should also be split out into a separate module in the same way. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Andrew F. Davis" <afd@ti.com> |
|---|---|
| Date | 2015-11-23 18:20 +0100 |
| Message-ID | <qy2Wu-4QZ-1@gated-at.bofh.it> |
| In reply to | #1275640 |
On 11/23/2015 10:57 AM, Arnd Bergmann wrote: > On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote: >> Separate out I2C functionality into a module. This fixes several small >> issues and simplifies the driver initialization. >> >> Signed-off-by: Andrew F. Davis <afd@ti.com> > > That looks good to me overall, it should help with the randconfig > warnings I've been seeing and makes the driver structured more logically. > > The one part I wonder about is whether the platform_driver portion > should also be split out into a separate module in the same way. > > Arnd > I think it should, I'm just waiting until I can find some time to bring up regmap for 1wire, then I can really clean things up and move the platform stuff (which is really the 1wire interface) out more cleanly, all I'll need to do then is just pass a regmap handle to the core from the interface modules. But that's all a project for another day :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-11-23 20:30 +0100 |
| Message-ID | <qy4Yj-697-25@gated-at.bofh.it> |
| In reply to | #1275649 |
On Monday 23 November 2015 11:09:50 Andrew F. Davis wrote: > On 11/23/2015 10:57 AM, Arnd Bergmann wrote: > > On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote: > >> Separate out I2C functionality into a module. This fixes several small > >> issues and simplifies the driver initialization. > >> > >> Signed-off-by: Andrew F. Davis <afd@ti.com> > > > > That looks good to me overall, it should help with the randconfig > > warnings I've been seeing and makes the driver structured more logically. > > > > The one part I wonder about is whether the platform_driver portion > > should also be split out into a separate module in the same way. > > > I think it should, I'm just waiting until I can find some time to > bring up regmap for 1wire, then I can really clean things up and > move the platform stuff (which is really the 1wire interface) out > more cleanly, all I'll need to do then is just pass a regmap handle > to the core from the interface modules. > > But that's all a project for another day Ok, sounds good. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web