Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module
Date	2015-11-23 18:00 +0100
Message-ID	<qy2D9-4un-41@gated-at.bofh.it> (permalink)
References	<qy2D9-4un-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote:
> Separate out I2C functionality into a module. This fixes several small
> issues and simplifies the driver initialization.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>

That looks good to me overall, it should help with the randconfig
warnings I've been seeing and makes the driver structured more logically.

The one part I wonder about is whether the platform_driver portion
should also be split out into a separate module in the same way.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module Arnd Bergmann <arnd@arndb.de> - 2015-11-23 18:00 +0100
  Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module "Andrew F. Davis" <afd@ti.com> - 2015-11-23 18:20 +0100
    Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module Arnd Bergmann <arnd@arndb.de> - 2015-11-23 20:30 +0100

csiph-web