Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1274926 > unrolled thread
| Started by | Jitendra Kumar Khasdev <jkhasdev@gmail.com> |
|---|---|
| First post | 2015-11-22 20:30 +0100 |
| Last post | 2015-11-23 11:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: comedi: Coding style warning fix for block comments Jitendra Kumar Khasdev <jkhasdev@gmail.com> - 2015-11-22 20:30 +0100
Re: [PATCH] staging: comedi: Coding style warning fix for block comments Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-22 20:30 +0100
Re: [PATCH] staging: comedi: Coding style warning fix for block comments Ian Abbott <abbotti@mev.co.uk> - 2015-11-23 11:30 +0100
Re: [PATCH] staging: comedi: Coding style warning fix for block comments Ian Abbott <abbotti@mev.co.uk> - 2015-11-23 11:40 +0100
| From | Jitendra Kumar Khasdev <jkhasdev@gmail.com> |
|---|---|
| Date | 2015-11-22 20:30 +0100 |
| Subject | [PATCH] staging: comedi: Coding style warning fix for block comments |
| Message-ID | <qxIuJ-88H-3@gated-at.bofh.it> |
This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl : I) Block comments use * on subsequent lines Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com> --- drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h index 56baf85..ccbe17b 100644 --- a/drivers/staging/comedi/comedilib.h +++ b/drivers/staging/comedi/comedilib.h @@ -1,20 +1,20 @@ /* - linux/include/comedilib.h - header file for kcomedilib - - COMEDI - Linux Control and Measurement Device Interface - Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org> - - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 2 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. -*/ + * linux/include/comedilib.h + * header file for kcomedilib + * + * COMEDI - Linux Control and Measurement Device Interface + * Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ #ifndef _LINUX_COMEDILIB_H #define _LINUX_COMEDILIB_H -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2015-11-22 20:30 +0100 |
| Message-ID | <qxIuK-88H-9@gated-at.bofh.it> |
| In reply to | #1274926 |
On Sun, Nov 22, 2015 at 9:19 PM, Jitendra Kumar Khasdev <jkhasdev@gmail.com> wrote: > This patch is to comedilib.h file that fixes up following warnings > reported by checkpatch.pl : > I) Block comments use * on subsequent lines > > Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com> > --- > drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h > index 56baf85..ccbe17b 100644 > --- a/drivers/staging/comedi/comedilib.h > +++ b/drivers/staging/comedi/comedilib.h > @@ -1,20 +1,20 @@ > /* > - linux/include/comedilib.h I don't think the file name is somehow useful here. > - header file for kcomedilib Perhaps * Header file for kcomedilib. > - > - COMEDI - Linux Control and Measurement Device Interface > - Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org> > - > - This program is free software; you can redistribute it and/or modify > - it under the terms of the GNU General Public License as published by > - the Free Software Foundation; either version 2 of the License, or > - (at your option) any later version. > - > - This program is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - GNU General Public License for more details. > -*/ > + * linux/include/comedilib.h > + * header file for kcomedilib > + * > + * COMEDI - Linux Control and Measurement Device Interface > + * Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > > #ifndef _LINUX_COMEDILIB_H > #define _LINUX_COMEDILIB_H > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| Date | 2015-11-23 11:30 +0100 |
| Subject | Re: [PATCH] staging: comedi: Coding style warning fix for block comments |
| Message-ID | <qxWxI-tE-3@gated-at.bofh.it> |
| In reply to | #1274928 |
On 22/11/15 19:24, Andy Shevchenko wrote: > On Sun, Nov 22, 2015 at 9:19 PM, Jitendra Kumar Khasdev > <jkhasdev@gmail.com> wrote: >> This patch is to comedilib.h file that fixes up following warnings >> reported by checkpatch.pl : >> I) Block comments use * on subsequent lines >> >> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com> >> --- >> drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++---------------- >> 1 file changed, 16 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h >> index 56baf85..ccbe17b 100644 >> --- a/drivers/staging/comedi/comedilib.h >> +++ b/drivers/staging/comedi/comedilib.h >> @@ -1,20 +1,20 @@ >> /* >> - linux/include/comedilib.h > > I don't think the file name is somehow useful here. To be fair, this patch is merely fixing the comment style, rather than changing the contents. Although I wouldn't mind if this line were changed, especially as the existing pathname is wrong. It could be changed to be just the basename of the header file like this: * comedilib.h which is similar to the header comment in comedidev.h. > > >> - header file for kcomedilib > > Perhaps > > * Header file for kcomedilib. No objections there. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| Date | 2015-11-23 11:40 +0100 |
| Subject | Re: [PATCH] staging: comedi: Coding style warning fix for block comments |
| Message-ID | <qxWHp-x4-31@gated-at.bofh.it> |
| In reply to | #1274926 |
On 22/11/15 19:19, Jitendra Kumar Khasdev wrote: > This patch is to comedilib.h file that fixes up following warnings > reported by checkpatch.pl : > I) Block comments use * on subsequent lines > > Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com> > --- > drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) Please could you mention comedilib.h in the Subject line? E.g.: staging: comedi: comedilib.h: Fix block comments It helps to localize the affected area more. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web