Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275217

Re: [PATCH] staging: comedi: Coding style warning fix for block comments

Show all headers | View raw

On 22/11/15 19:24, Andy Shevchenko wrote:
> On Sun, Nov 22, 2015 at 9:19 PM, Jitendra Kumar Khasdev
> <jkhasdev@gmail.com> wrote:
>> This patch is to comedilib.h file that fixes up following warnings
>> reported by checkpatch.pl :
>> I) Block comments use * on subsequent lines
>>
>> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
>> ---
>>   drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
>>   1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
>> index 56baf85..ccbe17b 100644
>> --- a/drivers/staging/comedi/comedilib.h
>> +++ b/drivers/staging/comedi/comedilib.h
>> @@ -1,20 +1,20 @@
>>   /*
>> -    linux/include/comedilib.h
>
> I don't think the file name is somehow useful here.

To be fair, this patch is merely fixing the comment style, rather than 
changing the contents.  Although I wouldn't mind if this line were 
changed, especially as the existing pathname is wrong.

It could be changed to be just the basename of the header file like this:

  * comedilib.h

which is similar to the header comment in comedidev.h.

>
>
>> -    header file for kcomedilib
>
> Perhaps
>
> * Header file for kcomedilib.

No objections there.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: comedi: Coding style warning fix for block comments Jitendra Kumar Khasdev <jkhasdev@gmail.com> - 2015-11-22 20:30 +0100
  Re: [PATCH] staging: comedi: Coding style warning fix for block comments Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-22 20:30 +0100
    Re: [PATCH] staging: comedi: Coding style warning fix for block  comments Ian Abbott <abbotti@mev.co.uk> - 2015-11-23 11:30 +0100
  Re: [PATCH] staging: comedi: Coding style warning fix for block  comments Ian Abbott <abbotti@mev.co.uk> - 2015-11-23 11:40 +0100

csiph-web