Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1272490 > unrolled thread

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

Started byHauke Mehrtens <hauke@hauke-m.de>
First post2015-11-18 20:20 +0100
Last post2015-11-25 10:20 +0100
Articles 11 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Hauke Mehrtens <hauke@hauke-m.de> - 2015-11-18 20:20 +0100
    Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Florian Fainelli <f.fainelli@gmail.com> - 2015-11-18 20:30 +0100
      Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Kalle Valo <kvalo@codeaurora.org> - 2015-11-19 09:00 +0100
        Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Arend van Spriel <arend@broadcom.com> - 2015-11-20 23:00 +0100
    Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Kalle Valo <kvalo@codeaurora.org> - 2015-11-19 08:50 +0100
      Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Arend van Spriel <arend@broadcom.com> - 2015-11-20 23:00 +0100
        Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Hauke Mehrtens <hauke@hauke-m.de> - 2015-11-21 14:50 +0100
        Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Kalle Valo <kvalo@codeaurora.org> - 2015-11-22 18:30 +0100
          Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Arend van Spriel <arend@broadcom.com> - 2015-11-23 11:30 +0100
            Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Arend van Spriel <arend@broadcom.com> - 2015-11-23 11:40 +0100
              Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Kalle Valo <kvalo@codeaurora.org> - 2015-11-25 10:20 +0100

#1272490 — Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

FromHauke Mehrtens <hauke@hauke-m.de>
Date2015-11-18 20:20 +0100
SubjectRe: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory
Message-ID<qwgqS-7b9-23@gated-at.bofh.it>
On 11/18/2015 03:45 PM, Kalle Valo wrote:
> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
> edit Makefiles from subdirectories to use the new location.
> 
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> ---

I would prefer to remove the brcm80211 directory in this process and create:
drivers/net/wireless/broadcom/brcmfmac
drivers/net/wireless/broadcom/brcmsmac
drivers/net/wireless/broadcom/brcmutil
drivers/net/wireless/broadcom/include

This way we have one directory less.

Hauke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1272499

FromFlorian Fainelli <f.fainelli@gmail.com>
Date2015-11-18 20:30 +0100
Message-ID<qwgAy-7es-21@gated-at.bofh.it>
In reply to#1272490
On 18/11/15 11:19, Hauke Mehrtens wrote:
> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
>> edit Makefiles from subdirectories to use the new location.
>>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>> ---
> 
> I would prefer to remove the brcm80211 directory in this process and create:
> drivers/net/wireless/broadcom/brcmfmac
> drivers/net/wireless/broadcom/brcmsmac
> drivers/net/wireless/broadcom/brcmutil
> drivers/net/wireless/broadcom/include
> 
> This way we have one directory less.

Would not that make keeping track of the previous and future history
harder for people contributing to these drivers? I could imagine that
for Arend and other Broadcom engineers, dealing with a simple level move
would be manageable, but having to account for a different directory
hierarchy could be a pain.

What is the impact on compat-wireless after/before these changes by the way?
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1272905

FromKalle Valo <kvalo@codeaurora.org>
Date2015-11-19 09:00 +0100
Message-ID<qwsim-6pI-1@gated-at.bofh.it>
In reply to#1272499
Florian Fainelli <f.fainelli@gmail.com> writes:

> On 18/11/15 11:19, Hauke Mehrtens wrote:
>> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>>> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
>>> edit Makefiles from subdirectories to use the new location.
>>>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>> ---
>> 
>> I would prefer to remove the brcm80211 directory in this process and create:
>> drivers/net/wireless/broadcom/brcmfmac
>> drivers/net/wireless/broadcom/brcmsmac
>> drivers/net/wireless/broadcom/brcmutil
>> drivers/net/wireless/broadcom/include
>> 
>> This way we have one directory less.
>
> Would not that make keeping track of the previous and future history
> harder for people contributing to these drivers? I could imagine that
> for Arend and other Broadcom engineers, dealing with a simple level move
> would be manageable, but having to account for a different directory
> hierarchy could be a pain.
>
> What is the impact on compat-wireless after/before these changes by the way?

It's called backports nowadays :)

But I understood that as long as we have a separate kconfig option for
the vendor directories (CONFIG_WLAN_VENDOR_*) it should be ok. For 4.3
we didn't have that for realtek directory and that caused pain for
backports.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274450

FromArend van Spriel <arend@broadcom.com>
Date2015-11-20 23:00 +0100
Message-ID<qx1SO-4ve-15@gated-at.bofh.it>
In reply to#1272905
On 11/19/2015 08:54 AM, Kalle Valo wrote:
> Florian Fainelli <f.fainelli@gmail.com> writes:
>
>> On 18/11/15 11:19, Hauke Mehrtens wrote:
>>> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>>>> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
>>>> edit Makefiles from subdirectories to use the new location.
>>>>
>>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>>> ---
>>>
>>> I would prefer to remove the brcm80211 directory in this process and create:
>>> drivers/net/wireless/broadcom/brcmfmac
>>> drivers/net/wireless/broadcom/brcmsmac
>>> drivers/net/wireless/broadcom/brcmutil
>>> drivers/net/wireless/broadcom/include
>>>
>>> This way we have one directory less.
>>
>> Would not that make keeping track of the previous and future history
>> harder for people contributing to these drivers? I could imagine that
>> for Arend and other Broadcom engineers, dealing with a simple level move
>> would be manageable, but having to account for a different directory
>> hierarchy could be a pain.
>>
>> What is the impact on compat-wireless after/before these changes by the way?
>
> It's called backports nowadays :)
>
> But I understood that as long as we have a separate kconfig option for
> the vendor directories (CONFIG_WLAN_VENDOR_*) it should be ok. For 4.3
> we didn't have that for realtek directory and that caused pain for
> backports.

That is my understanding as well.

Regards,
Arend

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1272901

FromKalle Valo <kvalo@codeaurora.org>
Date2015-11-19 08:50 +0100
Message-ID<qws8G-6mi-11@gated-at.bofh.it>
In reply to#1272490
Hauke Mehrtens <hauke@hauke-m.de> writes:

> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
>> edit Makefiles from subdirectories to use the new location.
>> 
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>> ---
>
> I would prefer to remove the brcm80211 directory in this process and create:
> drivers/net/wireless/broadcom/brcmfmac
> drivers/net/wireless/broadcom/brcmsmac
> drivers/net/wireless/broadcom/brcmutil
> drivers/net/wireless/broadcom/include
>
> This way we have one directory less.

I think this could be done separately. This patchset is big enough
already, I would not like to make it anymore complicated.

And I actually like the brcm80211 directory, I would not mind keeping it
still.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274448

FromArend van Spriel <arend@broadcom.com>
Date2015-11-20 23:00 +0100
Message-ID<qx1SN-4ve-5@gated-at.bofh.it>
In reply to#1272901
On 11/19/2015 08:48 AM, Kalle Valo wrote:
> Hauke Mehrtens <hauke@hauke-m.de> writes:
>
>> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>>> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
>>> edit Makefiles from subdirectories to use the new location.
>>>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>> ---
>>
>> I would prefer to remove the brcm80211 directory in this process and create:
>> drivers/net/wireless/broadcom/brcmfmac
>> drivers/net/wireless/broadcom/brcmsmac
>> drivers/net/wireless/broadcom/brcmutil
>> drivers/net/wireless/broadcom/include
>>
>> This way we have one directory less.
>
> I think this could be done separately. This patchset is big enough
> already, I would not like to make it anymore complicated.
>
> And I actually like the brcm80211 directory, I would not mind keeping it
> still.

I prefer to keep it as brcmsmac and brcmfmac rely on brcmutil module so 
I want to keep them together under brcm80211.

So does this patch go in before or after the patches I submitted before 
the merge window. I hope after :-p

Regards,
Arend

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274658

FromHauke Mehrtens <hauke@hauke-m.de>
Date2015-11-21 14:50 +0100
Message-ID<qxgIa-5XE-13@gated-at.bofh.it>
In reply to#1274448
On 11/20/2015 10:53 PM, Arend van Spriel wrote:
> On 11/19/2015 08:48 AM, Kalle Valo wrote:
>> Hauke Mehrtens <hauke@hauke-m.de> writes:
>>
>>> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>>>> Part of reorganising wireless drivers directory and Kconfig. Note
>>>> that I had to
>>>> edit Makefiles from subdirectories to use the new location.
>>>>
>>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>>> ---
>>>
>>> I would prefer to remove the brcm80211 directory in this process and
>>> create:
>>> drivers/net/wireless/broadcom/brcmfmac
>>> drivers/net/wireless/broadcom/brcmsmac
>>> drivers/net/wireless/broadcom/brcmutil
>>> drivers/net/wireless/broadcom/include
>>>
>>> This way we have one directory less.
>>
>> I think this could be done separately. This patchset is big enough
>> already, I would not like to make it anymore complicated.
>>
>> And I actually like the brcm80211 directory, I would not mind keeping it
>> still.
> 
> I prefer to keep it as brcmsmac and brcmfmac rely on brcmutil module so
> I want to keep them together under brcm80211.
> 
> So does this patch go in before or after the patches I submitted before
> the merge window. I hope after :-p

Ok, then leave it like Kalle proposed. backports should work with both
versions.

Hauke

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274912

FromKalle Valo <kvalo@codeaurora.org>
Date2015-11-22 18:30 +0100
Message-ID<qxGCB-6UK-1@gated-at.bofh.it>
In reply to#1274448
Arend van Spriel <arend@broadcom.com> writes:

> On 11/19/2015 08:48 AM, Kalle Valo wrote:
>> Hauke Mehrtens <hauke@hauke-m.de> writes:
>>
>>> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>>>> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
>>>> edit Makefiles from subdirectories to use the new location.
>>>>
>>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>>> ---
>>>
>>> I would prefer to remove the brcm80211 directory in this process and create:
>>> drivers/net/wireless/broadcom/brcmfmac
>>> drivers/net/wireless/broadcom/brcmsmac
>>> drivers/net/wireless/broadcom/brcmutil
>>> drivers/net/wireless/broadcom/include
>>>
>>> This way we have one directory less.
>>
>> I think this could be done separately. This patchset is big enough
>> already, I would not like to make it anymore complicated.
>>
>> And I actually like the brcm80211 directory, I would not mind keeping it
>> still.
>
> I prefer to keep it as brcmsmac and brcmfmac rely on brcmutil module
> so I want to keep them together under brcm80211.
>
> So does this patch go in before or after the patches I submitted
> before the merge window. I hope after :-p

Sorry, the vendor patches go in first :) It's much safer that way.

But I think that git should be smart enough and your patchset from
before the merge window should still apply without issues.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1275218

FromArend van Spriel <arend@broadcom.com>
Date2015-11-23 11:30 +0100
Message-ID<qxWxI-tE-15@gated-at.bofh.it>
In reply to#1274912
On 11/22/2015 06:23 PM, Kalle Valo wrote:
> Arend van Spriel <arend@broadcom.com> writes:
>
>> On 11/19/2015 08:48 AM, Kalle Valo wrote:
>>> Hauke Mehrtens <hauke@hauke-m.de> writes:
>>>
>>>> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>>>>> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
>>>>> edit Makefiles from subdirectories to use the new location.
>>>>>
>>>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>>>> ---
>>>>
>>>> I would prefer to remove the brcm80211 directory in this process and create:
>>>> drivers/net/wireless/broadcom/brcmfmac
>>>> drivers/net/wireless/broadcom/brcmsmac
>>>> drivers/net/wireless/broadcom/brcmutil
>>>> drivers/net/wireless/broadcom/include
>>>>
>>>> This way we have one directory less.
>>>
>>> I think this could be done separately. This patchset is big enough
>>> already, I would not like to make it anymore complicated.
>>>
>>> And I actually like the brcm80211 directory, I would not mind keeping it
>>> still.
>>
>> I prefer to keep it as brcmsmac and brcmfmac rely on brcmutil module
>> so I want to keep them together under brcm80211.
>>
>> So does this patch go in before or after the patches I submitted
>> before the merge window. I hope after :-p
>
> Sorry, the vendor patches go in first :) It's much safer that way.
>
> But I think that git should be smart enough and your patchset from
> before the merge window should still apply without issues.

Will see if that is true when I merge it in our internal repo. :-p

Thanks,
Arend

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1275229

FromArend van Spriel <arend@broadcom.com>
Date2015-11-23 11:40 +0100
Message-ID<qxWHo-x4-9@gated-at.bofh.it>
In reply to#1275218
On 11/23/2015 11:28 AM, Arend van Spriel wrote:
> On 11/22/2015 06:23 PM, Kalle Valo wrote:
>> Arend van Spriel <arend@broadcom.com> writes:
>>
>>> On 11/19/2015 08:48 AM, Kalle Valo wrote:
>>>> Hauke Mehrtens <hauke@hauke-m.de> writes:
>>>>
>>>>> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>>>>>> Part of reorganising wireless drivers directory and Kconfig. Note
>>>>>> that I had to
>>>>>> edit Makefiles from subdirectories to use the new location.
>>>>>>
>>>>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>>>>> ---
>>>>>
>>>>> I would prefer to remove the brcm80211 directory in this process
>>>>> and create:
>>>>> drivers/net/wireless/broadcom/brcmfmac
>>>>> drivers/net/wireless/broadcom/brcmsmac
>>>>> drivers/net/wireless/broadcom/brcmutil
>>>>> drivers/net/wireless/broadcom/include
>>>>>
>>>>> This way we have one directory less.
>>>>
>>>> I think this could be done separately. This patchset is big enough
>>>> already, I would not like to make it anymore complicated.
>>>>
>>>> And I actually like the brcm80211 directory, I would not mind
>>>> keeping it
>>>> still.
>>>
>>> I prefer to keep it as brcmsmac and brcmfmac rely on brcmutil module
>>> so I want to keep them together under brcm80211.
>>>
>>> So does this patch go in before or after the patches I submitted
>>> before the merge window. I hope after :-p
>>
>> Sorry, the vendor patches go in first :) It's much safer that way.
>>
>> But I think that git should be smart enough and your patchset from
>> before the merge window should still apply without issues.
>
> Will see if that is true when I merge it in our internal repo. :-p

Just applied the pending patches using 'git am -3' and that works fine. 
So when told to be smart, git is indeed smart ;-)

Regards,
Arend

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1277123

FromKalle Valo <kvalo@codeaurora.org>
Date2015-11-25 10:20 +0100
Message-ID<qyEp4-4c9-17@gated-at.bofh.it>
In reply to#1275229
Arend van Spriel <arend@broadcom.com> writes:

>>>> I prefer to keep it as brcmsmac and brcmfmac rely on brcmutil module
>>>> so I want to keep them together under brcm80211.
>>>>
>>>> So does this patch go in before or after the patches I submitted
>>>> before the merge window. I hope after :-p
>>>
>>> Sorry, the vendor patches go in first :) It's much safer that way.
>>>
>>> But I think that git should be smart enough and your patchset from
>>> before the merge window should still apply without issues.
>>
>> Will see if that is true when I merge it in our internal repo. :-p
>
> Just applied the pending patches using 'git am -3' and that works
> fine. So when told to be smart, git is indeed smart ;-)

Git is awesome :) Thanks for checking.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web