Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

From	Kalle Valo <kvalo@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory
Date	2015-11-19 09:00 +0100
Message-ID	<qwsim-6pI-1@gated-at.bofh.it> (permalink)
References	<qwcdA-4dg-7@gated-at.bofh.it> <qwcng-4gQ-19@gated-at.bofh.it> <qwgqS-7b9-23@gated-at.bofh.it> <qwgAy-7es-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Florian Fainelli <f.fainelli@gmail.com> writes:

> On 18/11/15 11:19, Hauke Mehrtens wrote:
>> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>>> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
>>> edit Makefiles from subdirectories to use the new location.
>>>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>> ---
>> 
>> I would prefer to remove the brcm80211 directory in this process and create:
>> drivers/net/wireless/broadcom/brcmfmac
>> drivers/net/wireless/broadcom/brcmsmac
>> drivers/net/wireless/broadcom/brcmutil
>> drivers/net/wireless/broadcom/include
>> 
>> This way we have one directory less.
>
> Would not that make keeping track of the previous and future history
> harder for people contributing to these drivers? I could imagine that
> for Arend and other Broadcom engineers, dealing with a simple level move
> would be manageable, but having to account for a different directory
> hierarchy could be a pain.
>
> What is the impact on compat-wireless after/before these changes by the way?

It's called backports nowadays :)

But I understood that as long as we have a separate kconfig option for
the vendor directories (CONFIG_WLAN_VENDOR_*) it should be ok. For 4.3
we didn't have that for realtek directory and that caused pain for
backports.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Hauke Mehrtens <hauke@hauke-m.de> - 2015-11-18 20:20 +0100
  Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Florian Fainelli <f.fainelli@gmail.com> - 2015-11-18 20:30 +0100
    Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Kalle Valo <kvalo@codeaurora.org> - 2015-11-19 09:00 +0100
      Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Arend van Spriel <arend@broadcom.com> - 2015-11-20 23:00 +0100
  Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Kalle Valo <kvalo@codeaurora.org> - 2015-11-19 08:50 +0100
    Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Arend van Spriel <arend@broadcom.com> - 2015-11-20 23:00 +0100
      Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Hauke Mehrtens <hauke@hauke-m.de> - 2015-11-21 14:50 +0100
      Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Kalle Valo <kvalo@codeaurora.org> - 2015-11-22 18:30 +0100
        Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Arend van Spriel <arend@broadcom.com> - 2015-11-23 11:30 +0100
          Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Arend van Spriel <arend@broadcom.com> - 2015-11-23 11:40 +0100
            Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory Kalle Valo <kvalo@codeaurora.org> - 2015-11-25 10:20 +0100

csiph-web