Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1272327 > unrolled thread
| Started by | Jitendra Kumar Khasdev <jkhasdev@gmail.com> |
|---|---|
| First post | 2015-11-18 17:00 +0100 |
| Last post | 2015-11-18 19:10 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c Jitendra Kumar Khasdev <jkhasdev@gmail.com> - 2015-11-18 17:00 +0100
Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c Greg KH <gregkh@linuxfoundation.org> - 2015-11-18 18:20 +0100
Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c Jitendra <jkhasdev@gmail.com> - 2015-11-18 18:40 +0100
Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2015-11-18 19:10 +0100
| From | Jitendra Kumar Khasdev <jkhasdev@gmail.com> |
|---|---|
| Date | 2015-11-18 17:00 +0100 |
| Subject | [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c |
| Message-ID | <qwdjm-4US-43@gated-at.bofh.it> |
This is a patch to the radio-bcm2048.c file that fixes up a brace warning found by the checkpatch.pl tool. Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com> --- drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index b10d601..6226e02 100644 --- a/drivers/staging/media/bcm2048/radio-bcm2048.c +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev, \ } #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \ -property_write(prop, signal size, mask, check) \ -property_read(prop, size, mask) +(property_write(prop, signal size, mask, check) \ +property_read(prop, size, mask)) #define property_str_read(prop, size) \ static ssize_t bcm2048_##prop##_read(struct device *dev, \ -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-11-18 18:20 +0100 |
| Subject | Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c |
| Message-ID | <qweyK-5X6-13@gated-at.bofh.it> |
| In reply to | #1272327 |
On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote: > This is a patch to the radio-bcm2048.c file that fixes up a brace warning > found by the checkpatch.pl tool. > > Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com> > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c > index b10d601..6226e02 100644 > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c > @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev, \ > } > > #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \ > -property_write(prop, signal size, mask, check) \ > -property_read(prop, size, mask) > +(property_write(prop, signal size, mask, check) \ > +property_read(prop, size, mask)) You didn't even test-build this patch, why not? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jitendra <jkhasdev@gmail.com> |
|---|---|
| Date | 2015-11-18 18:40 +0100 |
| Subject | Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c |
| Message-ID | <qweS7-63U-25@gated-at.bofh.it> |
| In reply to | #1272398 |
On Wednesday 18 November 2015 10:42 PM, Greg KH wrote:
> On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote:
>> This is a patch to the radio-bcm2048.c file that fixes up a brace warning
>> found by the checkpatch.pl tool.
>>
>> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
>> ---
>> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> index b10d601..6226e02 100644
>> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
>> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev, \
>> }
>>
>> #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \
>> -property_write(prop, signal size, mask, check) \
>> -property_read(prop, size, mask)
>> +(property_write(prop, signal size, mask, check) \
>> +property_read(prop, size, mask))
> You didn't even test-build this patch, why not?
>
Greg KH, I have compiled the kernel by following these step:
1. copied the .config files
2. make defconfig
3. make -j6
It doesn't show me any warning. so I have tested on my side.
--
Thanks and Regards,
Jitendra Kumar Khasdev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Mauro Carvalho Chehab <mchehab@osg.samsung.com> |
|---|---|
| Date | 2015-11-18 19:10 +0100 |
| Subject | Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c |
| Message-ID | <qwfl9-6tM-31@gated-at.bofh.it> |
| In reply to | #1272409 |
Em Wed, 18 Nov 2015 23:05:27 +0530 Jitendra <jkhasdev@gmail.com> escreveu: > > > On Wednesday 18 November 2015 10:42 PM, Greg KH wrote: > > On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote: > >> This is a patch to the radio-bcm2048.c file that fixes up a brace warning > >> found by the checkpatch.pl tool. > >> > >> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com> > >> --- > >> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c > >> index b10d601..6226e02 100644 > >> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c > >> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c > >> @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev, \ > >> } > >> > >> #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \ > >> -property_write(prop, signal size, mask, check) \ > >> -property_read(prop, size, mask) > >> +(property_write(prop, signal size, mask, check) \ > >> +property_read(prop, size, mask)) > > You didn't even test-build this patch, why not? > > > Greg KH, I have compiled the kernel by following these step: > 1. copied the .config files > 2. make defconfig > 3. make -j6 > It doesn't show me any warning. so I have tested on my side. defconfig won't compile all drivers. you need allyesconfig and/or allmodconfig. > -- > Thanks and Regards, > Jitendra Kumar Khasdev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web