Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1272409

Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c

Show all headers | View raw

On Wednesday 18 November 2015 10:42 PM, Greg KH wrote:
> On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote:
>> This is a patch to the radio-bcm2048.c file that fixes up a brace warning
>> found by the checkpatch.pl tool.
>>
>> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
>> ---
>>  drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> index b10d601..6226e02 100644
>> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
>> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
>>  }
>>  
>>  #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check)		\
>> -property_write(prop, signal size, mask, check)				\
>> -property_read(prop, size, mask)
>> +(property_write(prop, signal size, mask, check)				\
>> +property_read(prop, size, mask))
> You didn't even test-build this patch, why not?
>
Greg KH, I have compiled the kernel by following these step:
                1. copied the .config files
                2. make defconfig
                3. make -j6
 It doesn't show me any warning. so I have tested on my side.
--
Thanks and Regards,
Jitendra Kumar Khasdev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c Jitendra Kumar Khasdev <jkhasdev@gmail.com> - 2015-11-18 17:00 +0100
  Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in  radio-bcm2048.c Greg KH <gregkh@linuxfoundation.org> - 2015-11-18 18:20 +0100
    Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in  radio-bcm2048.c Jitendra <jkhasdev@gmail.com> - 2015-11-18 18:40 +0100
      Re: [PATCH] staging: media: bcm2048: fix brace coding style issue  in radio-bcm2048.c Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2015-11-18 19:10 +0100

csiph-web