Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273233 > unrolled thread

Re: [PATCH] w1: w1_process() is not freezable kthread

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] w1: w1_process() is not freezable kthread Jiri Kosina <jikos@kernel.org> - 2015-11-19 16:50 +0100
    Re: [PATCH] w1: w1_process() is not freezable kthread GregKH <greg@kroah.com> - 2015-11-19 17:20 +0100

#1273233 — Re: [PATCH] w1: w1_process() is not freezable kthread

On Thu, 5 Nov 2015, Evgeniy Polyakov wrote:

> > I fail to see why this kthread should be freezable at all. There is no way
> > for w1 device to generate new I/O requests that should be written out to
> > filesystem, is it?
> 
> w1 doesn't generate such requests, but it was more to make this thread
> consistent with majority of other threads in the kernel.

Most of which actually don't need freezer at all, and only contribute to 
the overall confusion regarding what kthread freezer is actually for.

It's my long-term goal to fix this situation (and this patch is part of 
some preparatory steps :) ).

> Ok, I'm not against it, Greg please pull this patch into your tree.
> 
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

Greg, do you plan to take this please? I don't seem to see it in 
linux-next as of today.

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1273262

On Thu, Nov 19, 2015 at 04:49:41PM +0100, Jiri Kosina wrote:
> On Thu, 5 Nov 2015, Evgeniy Polyakov wrote:
> 
> > > I fail to see why this kthread should be freezable at all. There is no way
> > > for w1 device to generate new I/O requests that should be written out to
> > > filesystem, is it?
> > 
> > w1 doesn't generate such requests, but it was more to make this thread
> > consistent with majority of other threads in the kernel.
> 
> Most of which actually don't need freezer at all, and only contribute to 
> the overall confusion regarding what kthread freezer is actually for.
> 
> It's my long-term goal to fix this situation (and this patch is part of 
> some preparatory steps :) ).
> 
> > Ok, I'm not against it, Greg please pull this patch into your tree.
> > 
> > Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> 
> Greg, do you plan to take this please? I don't seem to see it in 
> linux-next as of today.

Give me a chance to catch up on things, the merge window was just over
and I just returned from another conference...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web