Re: [PATCH] w1: w1_process() is not freezable kthread

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] w1: w1_process() is not freezable kthread
Date	2015-11-19 16:50 +0100
Message-ID	<qwzDc-2M9-25@gated-at.bofh.it> (permalink)
References	<qnIZ4-4nx-3@gated-at.bofh.it> <qodzQ-6jT-29@gated-at.bofh.it> <qort9-6PV-17@gated-at.bofh.it> <qrt5o-7ln-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 5 Nov 2015, Evgeniy Polyakov wrote:

> > I fail to see why this kthread should be freezable at all. There is no way
> > for w1 device to generate new I/O requests that should be written out to
> > filesystem, is it?
> 
> w1 doesn't generate such requests, but it was more to make this thread
> consistent with majority of other threads in the kernel.

Most of which actually don't need freezer at all, and only contribute to 
the overall confusion regarding what kthread freezer is actually for.

It's my long-term goal to fix this situation (and this patch is part of 
some preparatory steps :) ).

> Ok, I'm not against it, Greg please pull this patch into your tree.
> 
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

Greg, do you plan to take this please? I don't seem to see it in 
linux-next as of today.

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] w1: w1_process() is not freezable kthread Jiri Kosina <jikos@kernel.org> - 2015-11-19 16:50 +0100
  Re: [PATCH] w1: w1_process() is not freezable kthread GregKH <greg@kroah.com> - 2015-11-19 17:20 +0100

csiph-web