Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270568 > unrolled thread

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller Måns Rullgård <mans@mansr.com> - 2015-11-16 22:00 +0100
    Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800  Ethernet controller David Miller <davem@davemloft.net> - 2015-11-16 22:20 +0100
      Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller Måns Rullgård <mans@mansr.com> - 2015-11-16 22:30 +0100

#1270568 — Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller <davem@davemloft.net> writes:

> From: Mans Rullgard <mans@mansr.com>
> Date: Mon, 16 Nov 2015 18:23:35 +0000
>
>> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi)
>
> "i" is passed in as a signed int here, but:
>
>> +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len)
>  ...
>> +		err = nb8800_alloc_rx(dev, i, true);
>
> It comes from an 'unsigned' value.
>
> Please pick one type and use it consistently.

Darn, missed one.

> Also, always fully spell out "unsigned int" rather than use "unsigned"
> as a shorthand.

OK

Anything else?

-- 
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1270585 — Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård <mans@mansr.com>
Date: Mon, 16 Nov 2015 20:59:18 +0000

> Anything else?

Sorry, when I find one problem I give you the feedback for that
and move on to the 100s of other patches I have in my queue.

Or would you like me to devote all of my time to just your driver
instead of taking everyone's submissions into consideration?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1270602

David Miller <davem@davemloft.net> writes:

> From: Måns Rullgård <mans@mansr.com>
> Date: Mon, 16 Nov 2015 20:59:18 +0000
>
>> Anything else?
>
> Sorry, when I find one problem I give you the feedback for that
> and move on to the 100s of other patches I have in my queue.

Some people prefer to comment on more than one issue, if present, per
patch iteration.  Apparently you're not one of them.

> Or would you like me to devote all of my time to just your driver
> instead of taking everyone's submissions into consideration?

Of course not.

-- 
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web