Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From	Måns Rullgård <mans@mansr.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller
Date	2015-11-16 22:00 +0100
Message-ID	<qvz2y-3Mz-3@gated-at.bofh.it> (permalink)
References	<qvwHo-2mv-11@gated-at.bofh.it> <qvz2y-3Mz-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

David Miller <davem@davemloft.net> writes:

> From: Mans Rullgard <mans@mansr.com>
> Date: Mon, 16 Nov 2015 18:23:35 +0000
>
>> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi)
>
> "i" is passed in as a signed int here, but:
>
>> +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len)
>  ...
>> +		err = nb8800_alloc_rx(dev, i, true);
>
> It comes from an 'unsigned' value.
>
> Please pick one type and use it consistently.

Darn, missed one.

> Also, always fully spell out "unsigned int" rather than use "unsigned"
> as a shorthand.

OK

Anything else?

-- 
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller Måns Rullgård <mans@mansr.com> - 2015-11-16 22:00 +0100
  Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800  Ethernet controller David Miller <davem@davemloft.net> - 2015-11-16 22:20 +0100
    Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller Måns Rullgård <mans@mansr.com> - 2015-11-16 22:30 +0100

csiph-web