Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1270369 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2015-11-16 18:00 +0100 |
| Last post | 2015-11-17 11:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] clocksource: disallow drivers for ARCH_USES_GETTIMEOFFSET Arnd Bergmann <arnd@arndb.de> - 2015-11-16 18:00 +0100
[tip:timers/urgent] clocksource: Disallow drivers for ARCH_USES_GETTIMEOFFSET tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2015-11-17 11:40 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-11-16 18:00 +0100 |
| Subject | [PATCH] clocksource: disallow drivers for ARCH_USES_GETTIMEOFFSET |
| Message-ID | <qvvih-1lM-3@gated-at.bofh.it> |
We can now select clocksource drivers like ti-32k and CONFIG_OF
on ancient machines that still use gettimeoffset, and the combination
results in a link error.
arch/arm/kernel/built-in.o: In function `time_init':
(.init.text+0xc28): undefined reference to `clocksource_probe'
The reason for this is that the Makefile is hidden behind
CONFIG_ARCH_USES_GETTIMEOFFSET, but the Kconfig file is not, and
it has shown up just now because the ti-32k driver was added
and can be selected using COMPILE_TEST on all platforms.
This patch hides the Kconfig menu in CONFIG_ARCH_USES_GETTIMEOFFSET
as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: dfedaf105d60 ("clocksource: ti-32k: make it depend on GENERIC_CLOCKSOURCE")
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index c479f815b99a..db240cb56da7 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -1,4 +1,5 @@
menu "Clock Source drivers"
+ depends on !ARCH_USES_GETTIMEOFFSET
config CLKSRC_OF
bool
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | tip-bot for Arnd Bergmann <tipbot@zytor.com> |
|---|---|
| Date | 2015-11-17 11:40 +0100 |
| Subject | [tip:timers/urgent] clocksource: Disallow drivers for ARCH_USES_GETTIMEOFFSET |
| Message-ID | <qvLQ6-3NL-3@gated-at.bofh.it> |
| In reply to | #1270369 |
Commit-ID: 3da6d49e847128378c30292848125cc3e207e5f7 Gitweb: http://git.kernel.org/tip/3da6d49e847128378c30292848125cc3e207e5f7 Author: Arnd Bergmann <arnd@arndb.de> AuthorDate: Mon, 16 Nov 2015 17:51:17 +0100 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Mon, 16 Nov 2015 19:07:08 +0100 clocksource: Disallow drivers for ARCH_USES_GETTIMEOFFSET We can now select clocksource drivers like ti-32k and CONFIG_OF on ancient machines that still use gettimeoffset, and the combination results in a link error. arch/arm/kernel/built-in.o: In function `time_init': (.init.text+0xc28): undefined reference to `clocksource_probe' The reason for this is that the Makefile is hidden behind CONFIG_ARCH_USES_GETTIMEOFFSET, but the Kconfig file is not, and it has shown up just now because the ti-32k driver was added and can be selected using COMPILE_TEST on all platforms. This patch hides the Kconfig menu in CONFIG_ARCH_USES_GETTIMEOFFSET as well. Fixes: dfedaf105d60 "clocksource: ti-32k: make it depend on GENERIC_CLOCKSOURCE" Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org Cc: Felipe Balbi <balbi@ti.com> Cc: Tony Lindgren <tony@atomide.com> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Link: http://lkml.kernel.org/r/7579471.4N90fYPQOK@wuerfel Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- drivers/clocksource/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 71cfdf7..2eb5f0e 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -1,4 +1,5 @@ menu "Clock Source drivers" + depends on !ARCH_USES_GETTIMEOFFSET config CLKSRC_OF bool -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web