Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270369

[PATCH] clocksource: disallow drivers for ARCH_USES_GETTIMEOFFSET

Show all headers | View raw

We can now select clocksource drivers like ti-32k and CONFIG_OF
on ancient machines that still use gettimeoffset, and the combination
results in a link error.

arch/arm/kernel/built-in.o: In function `time_init':
(.init.text+0xc28): undefined reference to `clocksource_probe'

The reason for this is that the Makefile is hidden behind
CONFIG_ARCH_USES_GETTIMEOFFSET, but the Kconfig file is not, and
it has shown up just now because the ti-32k driver was added
and can be selected using COMPILE_TEST on all platforms.

This patch hides the Kconfig menu in CONFIG_ARCH_USES_GETTIMEOFFSET
as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: dfedaf105d60 ("clocksource: ti-32k: make it depend on GENERIC_CLOCKSOURCE")

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index c479f815b99a..db240cb56da7 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -1,4 +1,5 @@
 menu "Clock Source drivers"
+	depends on !ARCH_USES_GETTIMEOFFSET
 
 config CLKSRC_OF
 	bool

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: disallow drivers for ARCH_USES_GETTIMEOFFSET Arnd Bergmann <arnd@arndb.de> - 2015-11-16 18:00 +0100
  [tip:timers/urgent] clocksource:   Disallow drivers for ARCH_USES_GETTIMEOFFSET tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2015-11-17 11:40 +0100

csiph-web