Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270299 > unrolled thread

[PATCH 0/6] serial: fixes and cleanups

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/6] serial: fixes and cleanups Arnd Bergmann <arnd@arndb.de> - 2015-11-16 16:50 +0100
    [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency to console Arnd Bergmann <arnd@arndb.de> - 2015-11-16 17:00 +0100
      Re: [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency  to console Stefan Agner <stefan@agner.ch> - 2015-11-17 01:40 +0100
    [PATCH 1/6] serial: export fsl8250_handle_irq Arnd Bergmann <arnd@arndb.de> - 2015-11-16 17:00 +0100
    [PATCH 6/6] serial: 8250: move of_serial code to 8250 directory Arnd Bergmann <arnd@arndb.de> - 2015-11-16 17:00 +0100
    [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL Arnd Bergmann <arnd@arndb.de> - 2015-11-16 17:00 +0100
      Re: [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-11-16 18:00 +0100
        Re: [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL Arnd Bergmann <arnd@arndb.de> - 2015-11-16 18:10 +0100

#1270299 — [PATCH 0/6] serial: fixes and cleanups

I've had these patches sitting in my randconfig branch for a while,
but have now gotten around to sending them. The first three are
bug fixes for harmless problems that have shown up recently,
so they should go into 4.4.

The other three are part of a cleanup that we've been meaning
to do for a while but that is not urgent at all.

Arnd Bergmann (6):
  serial: export fsl8250_handle_irq
  serial: fsl-lpuart: move SERIAL_EARLYCON dependency to console
  serial: mid8250: select CONFIG_RATIONAL
  serial: remove NWP serial support
  serial: of: CONFIG_SERIAL_8250 is always set
  serial: 8250: move of_serial code to 8250 directory

 drivers/tty/serial/8250/8250_fsl.c                 |   1 +
 drivers/tty/serial/{of_serial.c => 8250/8250_of.c} |  32 --
 drivers/tty/serial/8250/Kconfig                    |  10 +
 drivers/tty/serial/8250/Makefile                   |   1 +
 drivers/tty/serial/Kconfig                         |  29 +-
 drivers/tty/serial/Makefile                        |   2 -
 drivers/tty/serial/nwpserial.c                     | 477 ---------------------
 include/linux/nwpserial.h                          |  18 -
 include/uapi/linux/serial_core.h                   |   2 +-
 9 files changed, 14 insertions(+), 558 deletions(-)
 rename drivers/tty/serial/{of_serial.c => 8250/8250_of.c} (92%)
 delete mode 100644 drivers/tty/serial/nwpserial.c
 delete mode 100644 include/linux/nwpserial.h

-- 
2.1.0.rc2

Cc: Scott Wood <scottwood@freescale.com>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Benjamin Krill <ben@codiert.org>
Cc: linuxppc-dev@lists.ozlabs.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1270301 — [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency to console

The newly added earlycon support for lpuart adds a
'select SERIAL_EARLYCON' statement for the tty driver, but that
only uses earlycon when console support is present, and otherwise
results in a pointless build error:

drivers/built-in.o: In function `setup_earlycon':
:(.init.text+0x2c4c): undefined reference to `uart_parse_earlycon'

This changes the Kconfig statement to only select the earlycon
code if the console is also enabled, like all the other drivers
do already.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 1d59b382f1c4 ("serial: fsl_lpuart: add earlycon support")
Cc: Stefan Agner <stefan@agner.ch>
---
 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1aec4404062d..dbb8ac6afd40 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1539,13 +1539,13 @@ config SERIAL_FSL_LPUART
 	tristate "Freescale lpuart serial port support"
 	depends on HAS_DMA
 	select SERIAL_CORE
-	select SERIAL_EARLYCON
 	help
 	  Support for the on-chip lpuart on some Freescale SOCs.
 
 config SERIAL_FSL_LPUART_CONSOLE
 	bool "Console on Freescale lpuart serial port"
 	depends on SERIAL_FSL_LPUART=y
+	select SERIAL_EARLYCON
 	select SERIAL_CORE_CONSOLE
 	help
 	  If you have enabled the lpuart serial port on the Freescale SoCs,
-- 
2.1.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1270721 — Re: [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency to console

FWIW,

Acked-by: Stefan Agner <stefan@agner.ch>

On 2015-11-16 07:48, Arnd Bergmann wrote:
> The newly added earlycon support for lpuart adds a
> 'select SERIAL_EARLYCON' statement for the tty driver, but that
> only uses earlycon when console support is present, and otherwise
> results in a pointless build error:
> 
> drivers/built-in.o: In function `setup_earlycon':
> :(.init.text+0x2c4c): undefined reference to `uart_parse_earlycon'
> 
> This changes the Kconfig statement to only select the earlycon
> code if the console is also enabled, like all the other drivers
> do already.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 1d59b382f1c4 ("serial: fsl_lpuart: add earlycon support")
> Cc: Stefan Agner <stefan@agner.ch>
> ---
>  drivers/tty/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 1aec4404062d..dbb8ac6afd40 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1539,13 +1539,13 @@ config SERIAL_FSL_LPUART
>  	tristate "Freescale lpuart serial port support"
>  	depends on HAS_DMA
>  	select SERIAL_CORE
> -	select SERIAL_EARLYCON
>  	help
>  	  Support for the on-chip lpuart on some Freescale SOCs.
>  
>  config SERIAL_FSL_LPUART_CONSOLE
>  	bool "Console on Freescale lpuart serial port"
>  	depends on SERIAL_FSL_LPUART=y
> +	select SERIAL_EARLYCON
>  	select SERIAL_CORE_CONSOLE
>  	help
>  	  If you have enabled the lpuart serial port on the Freescale SoCs,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1270303 — [PATCH 1/6] serial: export fsl8250_handle_irq

fsl8250_handle_irq is now used by the of_serial driver, and that fails
if it is a loadable module:

ERROR: "fsl8250_handle_irq" [drivers/tty/serial/of_serial.ko] undefined!

This exports the symbol to avoid randconfig errors.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: d43b54d269d2 ("serial: Enable Freescale 16550 workaround on arm")
Cc: Scott Wood <scottwood@freescale.com>
---
 drivers/tty/serial/8250/8250_fsl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/8250_fsl.c b/drivers/tty/serial/8250/8250_fsl.c
index c0533a57ec53..910bfee5a88b 100644
--- a/drivers/tty/serial/8250/8250_fsl.c
+++ b/drivers/tty/serial/8250/8250_fsl.c
@@ -60,3 +60,4 @@ int fsl8250_handle_irq(struct uart_port *port)
 	spin_unlock_irqrestore(&up->port.lock, flags);
 	return 1;
 }
+EXPORT_SYMBOL_GPL(fsl8250_handle_irq);
-- 
2.1.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1270310 — [PATCH 6/6] serial: 8250: move of_serial code to 8250 directory

As the of-serial driver is now 8250 specific, we can move the
file to a more appropriate place in teh 8250 subdirectory and
adapt the Kconfig help text and file name.

I'm leaving the CONFIG_SERIAL_OF_PLATFORM symbol unchanged
to avoid breaking user configuration files unnecessarily.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/tty/serial/{of_serial.c => 8250/8250_of.c} |  0
 drivers/tty/serial/8250/Kconfig                    |  9 +++++++++
 drivers/tty/serial/8250/Makefile                   |  1 +
 drivers/tty/serial/Kconfig                         | 10 ----------
 drivers/tty/serial/Makefile                        |  1 -
 5 files changed, 10 insertions(+), 11 deletions(-)
 rename drivers/tty/serial/{of_serial.c => 8250/8250_of.c} (100%)

diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/8250/8250_of.c
similarity index 100%
rename from drivers/tty/serial/of_serial.c
rename to drivers/tty/serial/8250/8250_of.c
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index 6412f1455beb..f8507d718dd4 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -378,3 +378,12 @@ config SERIAL_8250_MID
 	  Selecting this option will enable handling of the extra features
 	  present on the UART found on Intel Medfield SOC and various other
 	  Intel platforms.
+
+config SERIAL_OF_PLATFORM
+	tristate "Devicetree based probing for 8250 ports"
+	depends on SERIAL_8250 && OF
+	help
+	  This option is used for all 8250 compatible serial ports that
+	  are probed through devicetree, including Open Firmware based
+	  PowerPC systems and embedded systems on architectures using the
+	  flattened device tree format.
diff --git a/drivers/tty/serial/8250/Makefile b/drivers/tty/serial/8250/Makefile
index e177f8681ada..4ecb80d3549a 100644
--- a/drivers/tty/serial/8250/Makefile
+++ b/drivers/tty/serial/8250/Makefile
@@ -28,5 +28,6 @@ obj-$(CONFIG_SERIAL_8250_MT6577)	+= 8250_mtk.o
 obj-$(CONFIG_SERIAL_8250_UNIPHIER)	+= 8250_uniphier.o
 obj-$(CONFIG_SERIAL_8250_INGENIC)	+= 8250_ingenic.o
 obj-$(CONFIG_SERIAL_8250_MID)		+= 8250_mid.o
+obj-$(CONFIG_SERIAL_8250_OF)		+= 8250_of.o
 
 CFLAGS_8250_ingenic.o += -I$(srctree)/scripts/dtc/libfdt
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index a9c2200fd528..6879a5785be7 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1094,16 +1094,6 @@ config SERIAL_NETX_CONSOLE
 	  If you have enabled the serial port on the Hilscher NetX SoC
 	  you can make it the console by answering Y to this option.
 
-config SERIAL_OF_PLATFORM
-	tristate "Serial port on Open Firmware platform bus"
-	depends on OF
-	depends on SERIAL_8250
-	help
-	  If you have a PowerPC based system that has serial ports
-	  on a platform specific bus, you should enable this option.
-	  Currently, only 8250 compatible ports are supported, but
-	  others can easily be added.
-
 config SERIAL_OMAP
 	tristate "OMAP serial port support"
 	depends on ARCH_OMAP2PLUS
diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
index ee8893317433..b391c9b31960 100644
--- a/drivers/tty/serial/Makefile
+++ b/drivers/tty/serial/Makefile
@@ -63,7 +63,6 @@ obj-$(CONFIG_SERIAL_ATMEL) += atmel_serial.o
 obj-$(CONFIG_SERIAL_UARTLITE) += uartlite.o
 obj-$(CONFIG_SERIAL_MSM) += msm_serial.o
 obj-$(CONFIG_SERIAL_NETX) += netx-serial.o
-obj-$(CONFIG_SERIAL_OF_PLATFORM) += of_serial.o
 obj-$(CONFIG_SERIAL_KGDB_NMI) += kgdb_nmi.o
 obj-$(CONFIG_SERIAL_KS8695) += serial_ks8695.o
 obj-$(CONFIG_SERIAL_OMAP) += omap-serial.o
-- 
2.1.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1270311 — [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL

The Intel MID support got split out from the PCI 8250 driver,
and that now causes a build error when no other driver selects
CONFIG_RATIONAL:

drivers/built-in.o: In function `mid8250_set_termios':
(.text+0x77418): undefined reference to `rational_best_approximation'

This adds an explicit 'select' like the combined driver had before.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: d9eda9bab237 ("serial: 8250_pci: Intel MID UART support to its own driver")
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/tty/serial/8250/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index e6f5e12a2d83..6412f1455beb 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -373,6 +373,7 @@ config SERIAL_8250_MID
 	depends on SERIAL_8250 && PCI
 	select HSU_DMA if SERIAL_8250_DMA
 	select HSU_DMA_PCI if X86_INTEL_MID
+	select RATIONAL
 	help
 	  Selecting this option will enable handling of the extra features
 	  present on the UART found on Intel Medfield SOC and various other
-- 
2.1.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1270375 — Re: [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL

On Mon, 2015-11-16 at 16:48 +0100, Arnd Bergmann wrote:
> The Intel MID support got split out from the PCI 8250 driver,
> and that now causes a build error when no other driver selects
> CONFIG_RATIONAL:

Already published.
https://lkml.org/lkml/2015/11/12/272

It's not first time you send patches that already have been published.

I think you use some testing automation which doesn't take into
consideration what is sent in mailing lists.

> 
> drivers/built-in.o: In function `mid8250_set_termios':
> (.text+0x77418): undefined reference to `rational_best_approximation'
> 
> This adds an explicit 'select' like the combined driver had before.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: d9eda9bab237 ("serial: 8250_pci: Intel MID UART support to its
> own driver")
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/tty/serial/8250/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/8250/Kconfig
> b/drivers/tty/serial/8250/Kconfig
> index e6f5e12a2d83..6412f1455beb 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -373,6 +373,7 @@ config SERIAL_8250_MID
>  	depends on SERIAL_8250 && PCI
>  	select HSU_DMA if SERIAL_8250_DMA
>  	select HSU_DMA_PCI if X86_INTEL_MID
> +	select RATIONAL
>  	help
>  	  Selecting this option will enable handling of the extra
> features
>  	  present on the UART found on Intel Medfield SOC and
> various other

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1270385 — Re: [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL

On Monday 16 November 2015 18:56:02 Andy Shevchenko wrote:
> On Mon, 2015-11-16 at 16:48 +0100, Arnd Bergmann wrote:
> > The Intel MID support got split out from the PCI 8250 driver,
> > and that now causes a build error when no other driver selects
> > CONFIG_RATIONAL:
> 
> Already published.
> https://lkml.org/lkml/2015/11/12/272
> 
> It's not first time you send patches that already have been published.
> 
> I think you use some testing automation which doesn't take into
> consideration what is sent in mailing lists.

Correct, it also ignores whatever patches other people have in private
git trees, in their mail clients or in their heads.

I try to send patches for things that break either on the first
day they are broken so mine comes first, or I wait a while to see
if a fix ends up in linux-next to give everyone else a chance to
get their patch into next so I can catch it on a rebase.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web