Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270721

Re: [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency to console

Show all headers | View raw

FWIW,

Acked-by: Stefan Agner <stefan@agner.ch>

On 2015-11-16 07:48, Arnd Bergmann wrote:
> The newly added earlycon support for lpuart adds a
> 'select SERIAL_EARLYCON' statement for the tty driver, but that
> only uses earlycon when console support is present, and otherwise
> results in a pointless build error:
> 
> drivers/built-in.o: In function `setup_earlycon':
> :(.init.text+0x2c4c): undefined reference to `uart_parse_earlycon'
> 
> This changes the Kconfig statement to only select the earlycon
> code if the console is also enabled, like all the other drivers
> do already.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 1d59b382f1c4 ("serial: fsl_lpuart: add earlycon support")
> Cc: Stefan Agner <stefan@agner.ch>
> ---
>  drivers/tty/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 1aec4404062d..dbb8ac6afd40 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1539,13 +1539,13 @@ config SERIAL_FSL_LPUART
>  	tristate "Freescale lpuart serial port support"
>  	depends on HAS_DMA
>  	select SERIAL_CORE
> -	select SERIAL_EARLYCON
>  	help
>  	  Support for the on-chip lpuart on some Freescale SOCs.
>  
>  config SERIAL_FSL_LPUART_CONSOLE
>  	bool "Console on Freescale lpuart serial port"
>  	depends on SERIAL_FSL_LPUART=y
> +	select SERIAL_EARLYCON
>  	select SERIAL_CORE_CONSOLE
>  	help
>  	  If you have enabled the lpuart serial port on the Freescale SoCs,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] serial: fixes and cleanups Arnd Bergmann <arnd@arndb.de> - 2015-11-16 16:50 +0100
  [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency to console Arnd Bergmann <arnd@arndb.de> - 2015-11-16 17:00 +0100
    Re: [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency  to console Stefan Agner <stefan@agner.ch> - 2015-11-17 01:40 +0100
  [PATCH 1/6] serial: export fsl8250_handle_irq Arnd Bergmann <arnd@arndb.de> - 2015-11-16 17:00 +0100
  [PATCH 6/6] serial: 8250: move of_serial code to 8250 directory Arnd Bergmann <arnd@arndb.de> - 2015-11-16 17:00 +0100
  [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL Arnd Bergmann <arnd@arndb.de> - 2015-11-16 17:00 +0100
    Re: [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-11-16 18:00 +0100
      Re: [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL Arnd Bergmann <arnd@arndb.de> - 2015-11-16 18:10 +0100

csiph-web