Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1271206 > unrolled thread

Re: [PATCH v2] gpiolib: tighten up ACPI legacy gpio lookups

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] gpiolib: tighten up ACPI legacy gpio lookups Linus Walleij <linus.walleij@linaro.org> - 2015-11-17 14:50 +0100
    Re: [PATCH v2] gpiolib: tighten up ACPI legacy gpio lookups Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-27 18:40 +0100

#1271206 — Re: [PATCH v2] gpiolib: tighten up ACPI legacy gpio lookups

On Wed, Nov 11, 2015 at 8:45 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:

> We should not fall back to the legacy unnamed gpio lookup style if the
> driver requests gpios with different names, because we'll give out the same
> gpio twice. Let's keep track of the names that were used for the device and
> only do the fallback for the first name used.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> v1: incorporated changes suggested by Mika Westerberg in response to the
> draft patch I posted in Goodix thread.
>
> v2: moved acpi_can_fallback_to_crs body to drivers/gpio/gpiolib-acpi.c
> and provided stub for !CONFIG_ACPI case to fix build error if ACPI is
> disabled.

Patch applied with Mika's ACK.

Had to fuzz a bit to make it apply, hope nothing breaks.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1278901

On Tue, Nov 17, 2015 at 02:43:14PM +0100, Linus Walleij wrote:
> On Wed, Nov 11, 2015 at 8:45 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> 
> > We should not fall back to the legacy unnamed gpio lookup style if the
> > driver requests gpios with different names, because we'll give out the same
> > gpio twice. Let's keep track of the names that were used for the device and
> > only do the fallback for the first name used.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >
> > v1: incorporated changes suggested by Mika Westerberg in response to the
> > draft patch I posted in Goodix thread.
> >
> > v2: moved acpi_can_fallback_to_crs body to drivers/gpio/gpiolib-acpi.c
> > and provided stub for !CONFIG_ACPI case to fix build error if ACPI is
> > disabled.
> 
> Patch applied with Mika's ACK.
> 
> Had to fuzz a bit to make it apply, hope nothing breaks.

Hmm, I'd like to get this patch into my tree as well to apply Irina's
goodix pieces on top to make sure they do not break. Would it be OK for
me to just apply the patch and hope git will sort it out when we merge
into next/mainline, you maybe you could prepare a 4.3-based branch with
the patch for me to pull?

Thanks!

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web