Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1271206

Re: [PATCH v2] gpiolib: tighten up ACPI legacy gpio lookups

Show all headers | View raw

On Wed, Nov 11, 2015 at 8:45 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:

> We should not fall back to the legacy unnamed gpio lookup style if the
> driver requests gpios with different names, because we'll give out the same
> gpio twice. Let's keep track of the names that were used for the device and
> only do the fallback for the first name used.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> v1: incorporated changes suggested by Mika Westerberg in response to the
> draft patch I posted in Goodix thread.
>
> v2: moved acpi_can_fallback_to_crs body to drivers/gpio/gpiolib-acpi.c
> and provided stub for !CONFIG_ACPI case to fix build error if ACPI is
> disabled.

Patch applied with Mika's ACK.

Had to fuzz a bit to make it apply, hope nothing breaks.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] gpiolib: tighten up ACPI legacy gpio lookups Linus Walleij <linus.walleij@linaro.org> - 2015-11-17 14:50 +0100
  Re: [PATCH v2] gpiolib: tighten up ACPI legacy gpio lookups Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-27 18:40 +0100

csiph-web