Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270671 > unrolled thread

[BUG] checkpatch: false positive for commits with quote characters

Back to article view | Back to linux.kernel

Contents

  [BUG] checkpatch: false positive for commits with quote characters Brian Norris <computersforpeace@gmail.com> - 2015-11-16 23:50 +0100
    Re: [BUG] checkpatch: false positive for commits with quote  characters Joe Perches <joe@perches.com> - 2015-11-17 18:50 +0100
      Re: [BUG] checkpatch: false positive for commits with quote  characters Brian Norris <computersforpeace@gmail.com> - 2015-11-17 19:10 +0100

#1270671 — [BUG] checkpatch: false positive for commits with quote characters

Hi,

What is the Blessed (TM) style for referencing commits that have quote
characters in their subject line? e.g., this commit:

commit 43163022927b6e7d202a7e6f939c3f392465494d
Author: Brian Norris <computersforpeace@gmail.com>
Date:   Tue May 19 14:38:22 2015 -0700

    mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"

Checkpatch reports false positive errors like this:

  ERROR: Please use git commit description style 'commit <12+ chars of
  sha1> ("<title line>")'

when I try to reference it on this patch:

  https://lkml.org/lkml/2015/11/16/826

I understand the double quoting is a little nasty to parse, but I think
that just means we should relax the regexes in checkpatch.pl. I could
try to patch myself, but I figured I'd just follow checkpatch's advice
instead:

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1271493 — Re: [BUG] checkpatch: false positive for commits with quote characters

On Mon, 2015-11-16 at 14:43 -0800, Brian Norris wrote:
> Hi,
> 
> What is the Blessed (TM) style for referencing commits that have quote
> characters in their subject line? e.g., this commit:
> 
> commit 43163022927b6e7d202a7e6f939c3f392465494d
> Author: Brian Norris <computersforpeace@gmail.com>
> Date:   Tue May 19 14:38:22 2015 -0700
> 
>     mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"
> 
> Checkpatch reports false positive errors like this:
> 
>   ERROR: Please use git commit description style 'commit <12+ chars of
>   sha1> ("")'

Hi Brian.

What version of checkpatch are you using?

Using linux-next:

$ git log --stat -p -1 --format=email 43163022927b6e7d202a7e6f939c3f392465494d | ./scripts/checkpatch.pl --strict -
total: 0 errors, 0 warnings, 0 checks, 53 lines checked

Your patch has no obvious style problems and is ready for submission.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1271513 — Re: [BUG] checkpatch: false positive for commits with quote characters

On Tue, Nov 17, 2015 at 09:48:27AM -0800, Joe Perches wrote:
> On Mon, 2015-11-16 at 14:43 -0800, Brian Norris wrote:
> > Hi,
> > 
> > What is the Blessed (TM) style for referencing commits that have quote
> > characters in their subject line? e.g., this commit:
> > 
> > commit 43163022927b6e7d202a7e6f939c3f392465494d
> > Author: Brian Norris <computersforpeace@gmail.com>
> > Date:   Tue May 19 14:38:22 2015 -0700
> > 
> >     mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"
> > 
> > Checkpatch reports false positive errors like this:
> > 
> >   ERROR: Please use git commit description style 'commit <12+ chars of
> >   sha1> ("")'
> 
> Hi Brian.
> 
> What version of checkpatch are you using?
> 
> Using linux-next:
> 
> $ git log --stat -p -1 --format=email 43163022927b6e7d202a7e6f939c3f392465494d | ./scripts/checkpatch.pl --strict -

I was referring to running checkpatch on this:

  https://lkml.org/lkml/2015/11/16/826

which *referenced* commit 43163022927b6e7d202a7e6f939c3f392465494d.
Sorry if that wasn't clear.

See below,
Brian

$ curl http://patchwork.ozlabs.org/patch/545234/mbox/ | scripts/checkpatch.pl -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3741    0  3741    0     0  11525      0 --:--:-- --:--:-- --:--:-- 11510
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"")'
#17: 
Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for

total: 1 errors, 0 warnings, 29 lines checked

Your patch has style problems, please review.

NOTE: Ignored message types: FILE_PATH_CHANGES

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web