Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270671

[BUG] checkpatch: false positive for commits with quote characters

Show all headers | View raw

Hi,

What is the Blessed (TM) style for referencing commits that have quote
characters in their subject line? e.g., this commit:

commit 43163022927b6e7d202a7e6f939c3f392465494d
Author: Brian Norris <computersforpeace@gmail.com>
Date:   Tue May 19 14:38:22 2015 -0700

    mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"

Checkpatch reports false positive errors like this:

  ERROR: Please use git commit description style 'commit <12+ chars of
  sha1> ("<title line>")'

when I try to reference it on this patch:

  https://lkml.org/lkml/2015/11/16/826

I understand the double quoting is a little nasty to parse, but I think
that just means we should relax the regexes in checkpatch.pl. I could
try to patch myself, but I figured I'd just follow checkpatch's advice
instead:

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[BUG] checkpatch: false positive for commits with quote characters Brian Norris <computersforpeace@gmail.com> - 2015-11-16 23:50 +0100
  Re: [BUG] checkpatch: false positive for commits with quote  characters Joe Perches <joe@perches.com> - 2015-11-17 18:50 +0100
    Re: [BUG] checkpatch: false positive for commits with quote  characters Brian Norris <computersforpeace@gmail.com> - 2015-11-17 19:10 +0100

csiph-web