Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1269549 > unrolled thread
| Started by | "Nicholas A. Bellinger" <nab@linux-iscsi.org> |
|---|---|
| First post | 2015-11-14 23:40 +0100 |
| Last post | 2015-11-15 02:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc() "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2015-11-14 23:40 +0100
Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc() Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-11-15 02:20 +0100
| From | "Nicholas A. Bellinger" <nab@linux-iscsi.org> |
|---|---|
| Date | 2015-11-14 23:40 +0100 |
| Subject | Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc() |
| Message-ID | <quREe-1t1-5@gated-at.bofh.it> |
Hi Luis, Apologies for the delayed response. On Mon, 2015-10-19 at 21:18 +0100, Luis de Bethencourt wrote: > Smatch complains about returning hard coded error codes, silence this > warning. > > drivers/target/iscsi/iscsi_target_parameters.c:211 iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > --- > > Hi, > > This doesn't change the functionality. It is just about using the more specific > errno. And at the same time silencing smatch. > > Thanks, > Luis > > drivers/target/iscsi/iscsi_target_parameters.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Applied to target-pending/queue-fixes. Thank you, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Date | 2015-11-15 02:20 +0100 |
| Message-ID | <quU94-39Z-5@gated-at.bofh.it> |
| In reply to | #1269549 |
On 14/11/15 22:31, Nicholas A. Bellinger wrote: > Hi Luis, > > Apologies for the delayed response. > No worries. I understand maintainers are very busy. Thanks for taking the time to review and merge :) Enjoy your weekend, Luis > On Mon, 2015-10-19 at 21:18 +0100, Luis de Bethencourt wrote: >> Smatch complains about returning hard coded error codes, silence this >> warning. >> >> drivers/target/iscsi/iscsi_target_parameters.c:211 iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy >> >> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> >> --- >> >> Hi, >> >> This doesn't change the functionality. It is just about using the more specific >> errno. And at the same time silencing smatch. >> >> Thanks, >> Luis >> >> drivers/target/iscsi/iscsi_target_parameters.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> > > Applied to target-pending/queue-fixes. > > Thank you, > > --nab > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web