Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc()

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc()
Date	2015-11-15 02:20 +0100
Message-ID	<quU94-39Z-5@gated-at.bofh.it> (permalink)
References	<qlp4u-6It-17@gated-at.bofh.it> <quREe-1t1-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 14/11/15 22:31, Nicholas A. Bellinger wrote:
> Hi Luis,
> 
> Apologies for the delayed response.
>

No worries. I understand maintainers are very busy.

Thanks for taking the time to review and merge :)

Enjoy your weekend,
Luis

 
> On Mon, 2015-10-19 at 21:18 +0100, Luis de Bethencourt wrote:
>> Smatch complains about returning hard coded error codes, silence this
>> warning.
>>
>> drivers/target/iscsi/iscsi_target_parameters.c:211 iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>> ---
>>
>> Hi,
>>
>> This doesn't change the functionality. It is just about using the more specific
>> errno. And at the same time silencing smatch.
>>
>> Thanks,
>> Luis
>>
>>  drivers/target/iscsi/iscsi_target_parameters.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
> 
> Applied to target-pending/queue-fixes.
> 
> Thank you,
> 
> --nab
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of  failed kmalloc() "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2015-11-14 23:40 +0100
  Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of  failed kmalloc() Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-11-15 02:20 +0100

csiph-web