Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1267519 > unrolled thread
| Started by | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| First post | 2015-11-11 23:50 +0100 |
| Last post | 2015-11-12 11:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-11 23:50 +0100
Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-11 23:50 +0100
Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs Matias Bjørling <m@bjorling.me> - 2015-11-12 11:10 +0100
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2015-11-11 23:50 +0100 |
| Subject | Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs |
| Message-ID | <qtMnf-s4-3@gated-at.bofh.it> |
On Wed, Oct 28, 2015 at 7:54 PM, Matias Bjørling <m@bjorling.me> wrote:
> +struct nvm_dev_ops {
[...]
> + uint8_t max_phys_sect;
> +};
> --- /dev/null
> +++ b/drivers/lightnvm/core.c
> +int nvm_register(struct request_queue *q, char *disk_name,
> + struct nvm_dev_ops *ops)
> +{
[...]
> + } else if (dev->ops->max_phys_sect > 256) {
drivers/nfc/nfcmrvl/i2c.c:52: warning: comparison is always false due
to limited range of data type
Indeed, max_phys_sect is "uint8_t", so its maximum value is 255.
> + pr_info("nvm: max sectors supported is 256.\n");
Hence this message is not correct. What's the intended maximum value?
255 or 256?
> + return -EINVAL;
> + }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2015-11-11 23:50 +0100 |
| Message-ID | <qtMnf-s4-9@gated-at.bofh.it> |
| In reply to | #1267519 |
On Wed, Nov 11, 2015 at 11:46 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Wed, Oct 28, 2015 at 7:54 PM, Matias Bjørling <m@bjorling.me> wrote:
>> +struct nvm_dev_ops {
>
> [...]
>
>> + uint8_t max_phys_sect;
>> +};
>
>> --- /dev/null
>> +++ b/drivers/lightnvm/core.c
>
>> +int nvm_register(struct request_queue *q, char *disk_name,
>> + struct nvm_dev_ops *ops)
>> +{
>
> [...]
>
>> + } else if (dev->ops->max_phys_sect > 256) {
>
> drivers/nfc/nfcmrvl/i2c.c:52: warning: comparison is always false due
> to limited range of data type
Oops, I copied the wrong warning. Obviously this was supposed to be
"drivers/lightnvm/core.c:322: warning: comparison is always false due
to limited range of data type"
> Indeed, max_phys_sect is "uint8_t", so its maximum value is 255.
>
>> + pr_info("nvm: max sectors supported is 256.\n");
>
> Hence this message is not correct. What's the intended maximum value?
> 255 or 256?
>
>> + return -EINVAL;
>> + }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Matias Bjørling <m@bjorling.me> |
|---|---|
| Date | 2015-11-12 11:10 +0100 |
| Message-ID | <qtWZk-7yp-17@gated-at.bofh.it> |
| In reply to | #1267519 |
On 11/11/2015 11:46 PM, Geert Uytterhoeven wrote:
> On Wed, Oct 28, 2015 at 7:54 PM, Matias Bjørling <m@bjorling.me> wrote:
>> +struct nvm_dev_ops {
>
> [...]
>
>> + uint8_t max_phys_sect;
>> +};
>
>> --- /dev/null
>> +++ b/drivers/lightnvm/core.c
>
>> +int nvm_register(struct request_queue *q, char *disk_name,
>> + struct nvm_dev_ops *ops)
>> +{
>
> [...]
>
>> + } else if (dev->ops->max_phys_sect > 256) {
>
> drivers/nfc/nfcmrvl/i2c.c:52: warning: comparison is always false due
> to limited range of data type
>
> Indeed, max_phys_sect is "uint8_t", so its maximum value is 255.
>
>> + pr_info("nvm: max sectors supported is 256.\n");
>
> Hence this message is not correct. What's the intended maximum value?
> 255 or 256?
Good catch. It'll be 256, the typically device driver supports 64. The
256 is just an upper sensible bound. I'll create a patch to make it an
unsigned short.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web